Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upd(emacs): 28.2 -> 29.1 #5129

Closed
wants to merge 8 commits into from
Closed

upd(emacs): 28.2 -> 29.1 #5129

wants to merge 8 commits into from

Conversation

vigress8
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the Update Package Use this to request pacscript update label Dec 26, 2023
@vigress8 vigress8 marked this pull request as draft December 26, 2023 18:31
Elsie19
Elsie19 requested changes Dec 27, 2023
View reviewed changes
Copy link
Member

@Elsie19 Elsie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails on everything except 2 Ubuntu runs.

@vigress8
Copy link
Contributor Author

Dependency naming shenanigans again. Will look into it when I have time

@vigress8 vigress8 marked this pull request as ready for review December 29, 2023 09:40
@vigress8 vigress8 requested a review from Elsie19 December 29, 2023 09:40
Elsie19
Elsie19 requested changes Dec 30, 2023
View reviewed changes
Copy link
Member

@Elsie19 Elsie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are we doing here with removing the config variables?

@vigress8
Copy link
Contributor Author

vigress8 commented Dec 30, 2023 •
edited
Loading

That level of configuration makes more sense for emacs-git. Most users who type pacstall -I emacs most likely want to just install the latest stable release of Emacs, without all of that.
It also makes this script an unmaintainable clusterfuck, with dependencies and flags scattered all over the place

@vigress8 vigress8 closed this Feb 3, 2024
@vigress8 vigress8 deleted the upd/emacs branch February 3, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elsie19 Elsie19 Elsie19 requested changes

Assignees

@vigress8 vigress8

Labels
Update Package Use this to request pacscript update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vigress8 @Elsie19