Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: exercism-cli-bin #5132

Merged
merged 3 commits into from
Dec 26, 2023
Merged

add: exercism-cli-bin #5132

merged 3 commits into from
Dec 26, 2023

Conversation

raindev
Copy link
Contributor

@raindev raindev commented Dec 26, 2023

Tested both on an x86_64 laptop and on an amd64 Pi 4.

@github-actions github-actions bot added the Package Add Use this to request a package to be added label Dec 26, 2023
Copy link
Member

@Elsie19 Elsie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this should be exercism-cli-bin

packages/exercism-cli/exercism-cli.pacscript Outdated Show resolved Hide resolved
@raindev
Copy link
Contributor Author

raindev commented Dec 26, 2023

I wasn't sure whether to call the package exercism-cli (more precise) or just exercism (more concise).

@Elsie19
Copy link
Member

Elsie19 commented Dec 26, 2023

well you are installing a binary, so it should be either exercism-bin or exercism-cli-bin if there is a gui alternative.

@raindev
Copy link
Contributor Author

raindev commented Dec 26, 2023

@Elsie19 by the same extent the watchexec package should also have been named with -bin suffix, I take?

And edit the description
@Elsie19
Copy link
Member

Elsie19 commented Dec 26, 2023

@Elsie19 by the same extent the watchexec package should also have been named with -bin suffix, I take?

👀 actually yeah can you make a PR to fix that?

@raindev
Copy link
Contributor Author

raindev commented Dec 26, 2023

well you are installing a binary, so it should be either exercism-bin or exercism-cli-bin if there is a gui alternative.

There's no GUI (used to be) alternative but the exercism website itself is also open source.

@Elsie19 Elsie19 changed the title add: exercism-cli add: exercism-cli-bin Dec 26, 2023
@raindev
Copy link
Contributor Author

raindev commented Dec 26, 2023

@Elsie19 I'm sorry for missing this in the previous PR, fixed in #5133

@raindev raindev marked this pull request as ready for review December 26, 2023 21:06
@Elsie19
Copy link
Member

Elsie19 commented Dec 26, 2023

@Elsie19 I'm sorry for missing this in the previous PR, fixed in #5133

it's ok it was my fault 😳

packagelist Outdated Show resolved Hide resolved
@Elsie19 Elsie19 merged commit d9f80ea into pacstall:master Dec 26, 2023
21 checks passed
packagelist Show resolved Hide resolved
@raindev raindev deleted the exercism-cli branch December 27, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package Add Use this to request a package to be added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants