-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: lunarclient-app
#5138
Merged
Merged
add: lunarclient-app
#5138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigress8
suggested changes
Dec 28, 2023
Elsie19
requested changes
Dec 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should have used pre-commit
but didn't because I can see tabs intead of spaces (https://github.com/pacstall/pacstall-programs#how-to-setup-the-environment-for-pacscript-development)
Elsie19
requested changes
Dec 28, 2023
Elsie19
requested changes
Dec 28, 2023
Added `lunarclient-app` package Bugfixes! Final changes Fix download link so CI works Forgot space... Commit suggestions, also add license warning Tabs to Spaces! Fix typos No more extraction
Mythbusters123
force-pushed
the
add/lunarclient-app
branch
from
December 28, 2023 21:30
c653bc7
to
5937c48
Compare
Elsie19
requested changes
Dec 28, 2023
Co-authored-by: Elsie <[email protected]>
Needs pacstall/pacstall#1023 to be merged and released. |
Fix hashes, also fix bad `install` command Fix wrong download url
Co-authored-by: Elsie <[email protected]> Fix downloading for the time being Fix hashes, also fix bad `install` command
…all-programs into add/lunarclient-app
…all-programs into add/lunarclient-app
Elsie19
approved these changes
Dec 29, 2023
Elsie19
requested changes
Dec 29, 2023
Elsie19
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress