Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: lunarclient-app #5138

Merged
merged 10 commits into from
Dec 29, 2023
Merged

Conversation

Mythbusters123
Copy link
Contributor

Progress

  • Edit packagelist
  • Add initial pacscript
  • Contact devs (Unsure if Lunar will care, closed source and likely not worried about Linux support)
  • Add maintainer to pacscript

@Mythbusters123
Copy link
Contributor Author

This should also close #1786 & #5137

packages/lunarclient-app/lunarclient-app.pacscript Outdated Show resolved Hide resolved
packages/lunarclient-app/lunarclient-app.pacscript Outdated Show resolved Hide resolved
packages/lunarclient-app/lunarclient-app.pacscript Outdated Show resolved Hide resolved
packages/lunarclient-app/lunarclient-app.pacscript Outdated Show resolved Hide resolved
packages/lunarclient-app/lunarclient-app.pacscript Outdated Show resolved Hide resolved
packages/lunarclient-app/lunarclient-app.pacscript Outdated Show resolved Hide resolved
packages/lunarclient-app/lunarclient-app.pacscript Outdated Show resolved Hide resolved
packages/lunarclient-app/lunarclient-app.pacscript Outdated Show resolved Hide resolved
Copy link
Member

@Elsie19 Elsie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should have used pre-commit but didn't because I can see tabs intead of spaces (https://github.com/pacstall/pacstall-programs#how-to-setup-the-environment-for-pacscript-development)

Added `lunarclient-app` package

Bugfixes!

Final changes

Fix download link so CI works

Forgot space...

Commit suggestions, also add license warning

Tabs to Spaces!

Fix typos

No more extraction
@Elsie19
Copy link
Member

Elsie19 commented Dec 28, 2023

Needs pacstall/pacstall#1023 to be merged and released.

Mythbusters123 and others added 6 commits December 28, 2023 18:08
Fix hashes, also fix bad `install` command

Fix wrong download url
Co-authored-by: Elsie <[email protected]>

Fix downloading for the time being

Fix hashes, also fix bad `install` command
@Elsie19 Elsie19 added the Package Add Use this to request a package to be added label Dec 29, 2023
@Elsie19 Elsie19 changed the title add lunarclient-app add: lunarclient-app Dec 29, 2023
@Elsie19 Elsie19 merged commit 962535d into pacstall:master Dec 29, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package Add Use this to request a package to be added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants