Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upd(goverlay): 1.0 -> 1.1.1 #5824

Merged
merged 28 commits into from
May 16, 2024
Merged

upd(goverlay): 1.0 -> 1.1.1 #5824

merged 28 commits into from
May 16, 2024

Conversation

Xdavius
Copy link
Contributor

@Xdavius Xdavius commented Apr 3, 2024

No description provided.

@github-actions github-actions bot added the Update Package Use this to request pacscript update label Apr 3, 2024
@Xdavius
Copy link
Contributor Author

Xdavius commented Apr 3, 2024

I have canceled my branch.. it has canceled all my PR ...

I don't understand the uninstall error.
I suppose the problem is pacdeps should be makepacdeps (but doesn't exists) .

@Xdavius
Copy link
Contributor Author

Xdavius commented Apr 3, 2024

Here the control file generated :

Depends: mangohud, fpc-laz, fpc-src, lazarus-project, libqt6pas6
Package: goverlay
Version: 1.1.1-pacstall1
Architecture: amd64
Section: Pacstall
Priority: optional
Build-Depends: git, libglu1-mesa-dev, qt6-base-dev
Conflicts: goverlay-bin
Replace: goverlay-bin
Maintainer: Xdavius <[email protected]>
Description: A GUI to help manage Vulkan/OpenGL overlays
Installed-Size: 4193

@oklopfer
Copy link
Member

oklopfer commented Apr 3, 2024

I have canceled my branch.. it has canceled all my PR ...

I don't understand the uninstall error. I suppose the problem is pacdeps should be makepacdeps (but doesn't exists) .

This seems to be an issue on the CI end, not yours. It has a flaw of removing pacstall packages in alphabetical order, instead of dependency order, meaning if an alphabetically higher up dependency of a package is removed for a parent package, that package will come down too, with it, and then be unable to be removed later, because it was already removed before.

Basically, in this case, fpc-laz-deb is being removed before goverlay, which is triggering goverlay to be removed at the same time:

The following packages will be REMOVED:
  fpc-laz goverlay lazarus-project

which then results in:

Removing fpc-src (3.2.2) ...
Running pacstall -R for goverlay...
[*] WARNING: Reading input from pipe
[*] WARNING: Prompts are disabled
[!] ERROR: goverlay is not installed

not something for you to be concerned about. However, can you please explain why both goverlay and goverlay-bin exist? In their current state, they are essentially identical.

@Xdavius
Copy link
Contributor Author

Xdavius commented Apr 3, 2024

Hi. Thank you for replying.

In fact, I have tested on my side. Uninstalling fpc-src uninstall goverlay. But I don't want this comportement... Because it's not an execution dependency, just a build one.

If you know the way to avoid this problem... (Not tested to declare empty depends, I don't know if it will do the trick...)

For your question, goverlay-bin is the binary provided by upstream. At this moment, it is still in qt5 version 1.0.

This one is qt6 and rebuilt from source. The distributions aren't totally compatible with it, making the use of qt6ct for exemple for the theme.

Originally, goverlay-bin was named goverlay, but was a bin. So I have updated the name of the package.

And goverlay is from source as it must be.

I will continue to maintain both, but -bin will be left on 1.0 version for a while.

Waiting for Noble to see If I can update without problems.

1 similar comment
@Xdavius
Copy link
Contributor Author

Xdavius commented Apr 4, 2024

Hi. Thank you for replying.

In fact, I have tested on my side. Uninstalling fpc-src uninstall goverlay. But I don't want this comportement... Because it's not an execution dependency, just a build one.

If you know the way to avoid this problem... (Not tested to declare empty depends, I don't know if it will do the trick...)

For your question, goverlay-bin is the binary provided by upstream. At this moment, it is still in qt5 version 1.0.

This one is qt6 and rebuilt from source. The distributions aren't totally compatible with it, making the use of qt6ct for exemple for the theme.

Originally, goverlay-bin was named goverlay, but was a bin. So I have updated the name of the package.

And goverlay is from source as it must be.

I will continue to maintain both, but -bin will be left on 1.0 version for a while.

Waiting for Noble to see If I can update without problems.

@Xdavius
Copy link
Contributor Author

Xdavius commented Apr 7, 2024

@Elsie19 I think it's good now.

@Elsie19 Elsie19 changed the title upd(goverlay):1.0 -> 1.1.1 upd(goverlay): 1.0 -> 1.1.1 Apr 7, 2024
packages/goverlay/goverlay.pacscript Outdated Show resolved Hide resolved
packages/goverlay/goverlay.pacscript Outdated Show resolved Hide resolved
@Xdavius Xdavius requested a review from Elsie19 April 19, 2024 11:22
@Xdavius
Copy link
Contributor Author

Xdavius commented Apr 28, 2024

@oklopfer possible to merge ? or miss something ? I have updated qt6pas pacscript so we need to up this one after.

@D-Brox
Copy link
Member

D-Brox commented May 5, 2024

This needs to be updated to the 5.0.0 spec

@Elsie19 Elsie19 added the blocked Unable to be merged due to some issue label May 6, 2024
@Xdavius
Copy link
Contributor Author

Xdavius commented May 9, 2024

This needs to be updated to the 5.0.0 spec

use goverlay-bin until I do the changes here. Have to test with v5.
i also need to patch /bin/goverlay and add qt6ct for theming because debian and ubuntu are behind of upstream

@Elsie19
Copy link
Member

Elsie19 commented May 11, 2024

There are merge conflicts now.

packages/goverlay/goverlay.pacscript Outdated Show resolved Hide resolved
@Elsie19 Elsie19 removed the blocked Unable to be merged due to some issue label May 16, 2024
@Elsie19 Elsie19 merged commit 8a828e6 into pacstall:master May 16, 2024
22 checks passed
@Xdavius Xdavius deleted the goverlay branch June 3, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Update Package Use this to request pacscript update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants