-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: lenovolegionlinux-dkms-git
, lenovolegionlinux-git
, python3-darkdetect
#6792
base: master
Are you sure you want to change the base?
Conversation
ae605a7
to
df2f8fd
Compare
5d90a22
to
6ee02d9
Compare
lenovolegionlinux-dkms-git
lenovolegionlinux-git
python3-darkdetect
lenovolegionlinux-dkms-git
lenovolegionlinux-git
python3-darkdetect
lenovolegionlinux-dkms-git
, lenovolegionlinux-git
, python3-darkdetect
packages/lenovolegionlinux-dkms-git/lenovolegionlinux-dkms-git.pacscript
Outdated
Show resolved
Hide resolved
packages/lenovolegionlinux-dkms-git/lenovolegionlinux-dkms-git.pacscript
Outdated
Show resolved
Hide resolved
packages/lenovolegionlinux-dkms-git/lenovolegionlinux-dkms-git.pacscript
Outdated
Show resolved
Hide resolved
packages/lenovolegionlinux-dkms-git/lenovolegionlinux-dkms-git.pacscript
Outdated
Show resolved
Hide resolved
packages/lenovolegionlinux-dkms-git/lenovolegionlinux-dkms-git.pacscript
Outdated
Show resolved
Hide resolved
packages/lenovolegionlinux-dkms-git/lenovolegionlinux-dkms-git.pacscript
Outdated
Show resolved
Hide resolved
packages/lenovolegionlinux-dkms-git/lenovolegionlinux-dkms-git.pacscript
Show resolved
Hide resolved
packages/lenovolegionlinux-dkms-git/lenovolegionlinux-dkms-git.pacscript
Outdated
Show resolved
Hide resolved
5070168
to
82077bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Follow https://github.com/pacstall/pacstall/wiki/101.3-Styling#other, especially the
shfmt
part. - Every variable/array should be "clumped together", with no newlines between variable declarations. The only time you do is after the last variable and before the first function, and subsequent functions.
- Please review https://github.com/pacstall/pacstall/wiki/101.1-Variables, because some practices you are doing in your scripts are just plopped into the pacscript without actually looking at what features we offer over PKGBUILDs (like the
maintainer
array).
073aede
to
7510ee6
Compare
Everything above should now be ok
Apart from the mantainer array I don't think I need to change any variable everything seems ok, but correct me if I wrong |
Just a git comment, but please don't force push every time. We like to see the progress of a PR, and it helps us see what comments were and weren't applied ;) |
Signed-off-by: Gonçalo Negrier Duarte <[email protected]>
Signed-off-by: Gonçalo Negrier Duarte <[email protected]>
Signed-off-by: Gonçalo Negrier Duarte <[email protected]>
4e2455c
to
266e06b
Compare
for more information, see https://pre-commit.ci
I used to make PR for gentoo ebuild and most of the times will force push to not became a mess in the commit history. |
packages/lenovolegionlinux-dkms-git/lenovolegionlinux-dkms-git.pacscript
Outdated
Show resolved
Hide resolved
We squash merge so it doesn't really matter in the end, but we just like linear pushes in the PR tab for easy history viewing. |
Signed-off-by: Gonçalo Negrier Duarte <[email protected]>
Signed-off-by: Gonçalo Negrier Duarte <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Gonçalo Negrier Duarte <[email protected]>
bc03286
to
318486c
Compare
Signed-off-by: Gonçalo Negrier Duarte <[email protected]>
cab10f2
to
0965173
Compare
for more information, see https://pre-commit.ci
packages/lenovolegionlinux-dkms-git/lenovolegionlinux-dkms-git.pacscript
Outdated
Show resolved
Hide resolved
packages/lenovolegionlinux-dkms-git/lenovolegionlinux-dkms-git.pacscript
Outdated
Show resolved
Hide resolved
The |
packages/lenovolegionlinux-dkms-git/lenovolegionlinux-dkms-git.pacscript
Outdated
Show resolved
Hide resolved
CC ?= clang | ||
|
||
CFLAGS ?= -O2 | ||
CFLAGS += -Wall -linih | ||
|
||
SRC = $(wildcard ini.c modules/*.c) | ||
OBJ = $(SRC:.c=.o) | ||
|
||
TARGET = legiond legiond-ctl | ||
all: $(TARGET) | ||
|
||
legiond: $(OBJ) legiond.o | ||
$(CC) $(CFLAGS) $(OBJ) legiond.o -o legiond | ||
|
||
legiond-ctl: legiond-ctl.o | ||
$(CC) $(CFLAGS) legiond-ctl.o -o legiond-ctl | ||
|
||
%.o : %.c | ||
$(CC) $(CFLAGS) -c $< -o $@ | ||
|
||
clean: | ||
rm -f $(OBJ) $(TARGET) legiond.o legiond-ctl.o | ||
|
||
.PHONY: all clean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar to my comment here, this should simply be text inside of the pacscript
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since is only one line changed I decided to use sed in the prepare instead of updating the file I gonna see if it work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now legiond compile with no problems
2992864
to
1a8cd6a
Compare
* move step to prepare
1a8cd6a
to
0c537cc
Compare
This add the Lenovolegionlinux git packages to pacstall all based on AUR ones.
lenovolegionlinux-git
lenovolegionlinux-dkms-git
This also add darkdetect python packages also based in the archlinux package.
python3-darkdetect