Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: lenovolegionlinux-dkms-git, lenovolegionlinux-git, python3-darkdetect #6792

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

MrDuartePT
Copy link

@MrDuartePT MrDuartePT commented Dec 27, 2024

This add the Lenovolegionlinux git packages to pacstall all based on AUR ones.
lenovolegionlinux-git
lenovolegionlinux-dkms-git

This also add darkdetect python packages also based in the archlinux package.
python3-darkdetect

@MrDuartePT MrDuartePT force-pushed the lenovolegionlinux branch 8 times, most recently from ae605a7 to df2f8fd Compare December 27, 2024 17:41
@Elsie19
Copy link
Member

Elsie19 commented Dec 27, 2024

Fix the title.

@MrDuartePT MrDuartePT changed the title Lenovolegionlinux pacstall packages add: lenovolegionlinux-dkms-git lenovolegionlinux-git python3-darkdetect Dec 27, 2024
@MrDuartePT MrDuartePT changed the title add: lenovolegionlinux-dkms-git lenovolegionlinux-git python3-darkdetect add: lenovolegionlinux-dkms-git lenovolegionlinux-git python3-darkdetect Dec 28, 2024
@MrDuartePT MrDuartePT changed the title add: lenovolegionlinux-dkms-git lenovolegionlinux-git python3-darkdetect add: lenovolegionlinux-dkms-git, lenovolegionlinux-git, python3-darkdetect Dec 28, 2024
Copy link
Member

@Elsie19 Elsie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Follow https://github.com/pacstall/pacstall/wiki/101.3-Styling#other, especially the shfmt part.
  2. Every variable/array should be "clumped together", with no newlines between variable declarations. The only time you do is after the last variable and before the first function, and subsequent functions.
  3. Please review https://github.com/pacstall/pacstall/wiki/101.1-Variables, because some practices you are doing in your scripts are just plopped into the pacscript without actually looking at what features we offer over PKGBUILDs (like the maintainer array).

@MrDuartePT
Copy link
Author

MrDuartePT commented Dec 31, 2024

  1. Follow https://github.com/pacstall/pacstall/wiki/101.3-Styling#other, especially the shfmt part.

  2. Every variable/array should be "clumped together", with no newlines between variable declarations. The only time you do is after the last variable and before the first function, and subsequent functions.

Everything above should now be ok

  1. Please review https://github.com/pacstall/pacstall/wiki/101.1-Variables, because some practices you are doing in your scripts are just plopped into the pacscript without actually looking at what features we offer over PKGBUILDs (like the maintainer array).

Apart from the mantainer array I don't think I need to change any variable everything seems ok, but correct me if I wrong

@Elsie19
Copy link
Member

Elsie19 commented Dec 31, 2024

Just a git comment, but please don't force push every time. We like to see the progress of a PR, and it helps us see what comments were and weren't applied ;)

Signed-off-by: Gonçalo Negrier Duarte <[email protected]>
Signed-off-by: Gonçalo Negrier Duarte <[email protected]>
Signed-off-by: Gonçalo Negrier Duarte <[email protected]>
@MrDuartePT
Copy link
Author

Just a git comment, but please don't force push every time. We like to see the progress of a PR, and it helps us see what comments were and weren't applied ;)

I used to make PR for gentoo ebuild and most of the times will force push to not became a mess in the commit history.
Sorry about that :)

@Elsie19
Copy link
Member

Elsie19 commented Dec 31, 2024

Just a git comment, but please don't force push every time. We like to see the progress of a PR, and it helps us see what comments were and weren't applied ;)

I used to make PR for gentoo ebuild and most of the times will force push to not became a mess in the commit history. Sorry about that :)

We squash merge so it doesn't really matter in the end, but we just like linear pushes in the PR tab for easy history viewing.

Signed-off-by: Gonçalo Negrier Duarte <[email protected]>
@MrDuartePT
Copy link
Author

For some reason installing lenovolegionlinux-git is giving me an error (sorry for picture it inside a vm):
image

I don't really get way it the frist distro this error appear (also I don't very familiar with deb package format)

@Elsie19
Copy link
Member

Elsie19 commented Jan 2, 2025

For some reason installing lenovolegionlinux-git is giving me an error (sorry for picture it inside a vm):
image

I don't really get way it the frist distro this error appear (also I don't very familiar with deb package format)

You're trying to overwrite a file from a different package.

@MrDuartePT
Copy link
Author

MrDuartePT commented Jan 2, 2025

You're trying to overwrite a file from a different package.

The -t in the install command solve it. For some weird reason the deb wanted to overwrite the entire /usr/bin folder

Comment on lines 1 to 24
CC ?= clang

CFLAGS ?= -O2
CFLAGS += -Wall -linih

SRC = $(wildcard ini.c modules/*.c)
OBJ = $(SRC:.c=.o)

TARGET = legiond legiond-ctl
all: $(TARGET)

legiond: $(OBJ) legiond.o
$(CC) $(CFLAGS) $(OBJ) legiond.o -o legiond

legiond-ctl: legiond-ctl.o
$(CC) $(CFLAGS) legiond-ctl.o -o legiond-ctl

%.o : %.c
$(CC) $(CFLAGS) -c $< -o $@

clean:
rm -f $(OBJ) $(TARGET) legiond.o legiond-ctl.o

.PHONY: all clean
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar to my comment here, this should simply be text inside of the pacscript

Copy link
Author

@MrDuartePT MrDuartePT Jan 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since is only one line changed I decided to use sed in the prepare instead of updating the file I gonna see if it work.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now legiond compile with no problems

@MrDuartePT MrDuartePT force-pushed the lenovolegionlinux branch 3 times, most recently from 2992864 to 1a8cd6a Compare January 12, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants