Skip to content

Commit

Permalink
Cran re-sub
Browse files Browse the repository at this point in the history
  • Loading branch information
levisc8 committed Apr 28, 2022
1 parent 03ea2f0 commit d408d98
Showing 1 changed file with 9 additions and 16 deletions.
25 changes: 9 additions & 16 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
This is an update of ipmr which is already on CRAN. This update includes bug fixes
and a new features. The last update was in mid September, 2021.
This is a resubmission of ipmr 0.0.5 from earlier today. This update includes bug fixes and a new features. The last update was in mid September, 2021. Additionally, it eliminates the following NOTE from the submission earlier today:

> checking R code for possible problems ... NOTE
.new_pdf: ... may be used in an incorrect context: 'rlang::enexprs(...)'
.unknown_op: ... may be used in an incorrect context: 'list(...)'

Per an email from Uwe Ligges, I've been told I can ignore the 503 errors regarding links and DOIs from the earlier submission.

Additional information on this submission:

Expand All @@ -12,21 +17,11 @@ Additional information on this submission:

## R CMD check results

0 errors | 0 warnings | 1 note on all platforms

> checking R code for possible problems ... NOTE
.new_pdf: ... may be used in an incorrect context: 'rlang::enexprs(...)'
.unknown_op: ... may be used in an incorrect context: 'list(...)'

.new_pdf() and .unknown_op() are functionals that capture arbitrary expressions to translate their arguments from R code into Latex. I don't think there are any issues with using ... in this context.

.new_pdf is defined here: https://github.com/levisc8/ipmr/blob/main/R/make_ipm_report.R#L471

.unknown_op is defined here: https://github.com/levisc8/ipmr/blob/main/R/make_ipm_report.R#L455
0 errors | 0 warnings | 0 note on all platforms

## Linux Ubuntu GCC R CMD check results

0 errors | 0 warnings | 2 notes
0 errors | 0 warnings | 1 note

checking installed package size ... NOTE

Expand All @@ -36,5 +31,3 @@ checking installed package size ... NOTE
> libs 2.6Mb
This is not unexpected in packages with compiled code as pointed out here: https://stackoverflow.com/questions/53819970/r-package-libs-directory-too-large-after-compilation-to-submit-on-cran

For second note, see above re: checks on all platforms.

0 comments on commit d408d98

Please sign in to comment.