[Sprite] Hotfix cut off Binacle sprite #4741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaosgrimmon
added
Sprite/Animation
MokaStitcher
approved these changes
Oct 27, 2024
MokaStitcher
added a commit
that referenced
this pull request
Oct 28, 2024
* Comment out startGame call on manifest fetch failure * [Hotfix] Fix status damage triggering before berry usage (#4732) * [Hotfix] Fix Eternatus egg tier (#4734) * [Hotfix] Fix manifest getting loaded before the game is initialized (#4739) * fix locales path for offline builds (#4739) * [Sprite] Hotfix cut off Binacle sprite (#4741) * [Sprite][hotfix] Fixed cropping on 658 static greninja and ash greninja (#4743) * [Sprite][hotfix] Fixed cropping on static greninja and ash greninja * [Hotfix] Fix crash when Mist would block a stat drop (#4746) --------- Co-authored-by: Frederico Santos <[email protected]> Co-authored-by: innerthunder <[email protected]> Co-authored-by: PigeonBar <[email protected]> Co-authored-by: chaosgrimmon <[email protected]> Co-authored-by: pom-eranian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Binacle sprites are now fully on screen
Why am I making these changes?
Reported here. The opportunity was also taken to trim unused fields from the Binacle front .jsons.
What are the changes from a developer perspective?
No mechanical differences, simple asset data modifications only.
Screenshots/Videos
Before
After
How to test the changes?
Start a run with Binacle of any rarity.
Checklist
- [ ] I'm usingbetaas my base branch- [ ] Have I considered writing automated tests for the issue?- [ ] If I have text, did I make it translatable and add a key in the English locale file(s)?npm run test)