[Move] Partially Implement Instruct

[Bertie690]

Locales PR (merged)

What are the changes the user will see?

Instruct will actually work and calls the target's last used move correctly.
It currently does not play nice with Gigaton Hammer, Blood Moon and Torment, but those are related to the janky implementation of those moves currently. #4289
Also pledge jank happens currently.
Also the enemy cannot really use it atm but that's a topic for the upcoming AI reworks!!!

Why am I making these changes?

Because I want funny klefki prankster instructing power trick shuckle rock slide.

What are the changes from a developer perspective?

Added RepeatMoveAttr for moves that force targets to repeat moves themselves. (This is distinct from CopyMoveAttr which has the user copy a target's previous move)

Screenshots/Videos

Instruct repeating an ally's rock slide & subsequently failing on enemy Unown due to it not having made moves yet:
https://github.com/user-attachments/assets/d4ee43d5-d324-4f5e-824d-76aac5e26ea1
It sorta works on pledges... a bit
https://github.com/user-attachments/assets/60490c80-57bd-43cd-8d0b-66ea511803bb
Instruct fails when used on Instruct (Full list of moves on Bulbapedia):
https://github.com/user-attachments/assets/b9a22fa2-ab67-4d1d-bd6b-81b855fa545a

How to test the changes?

Run npm run test instruct

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I considered writing automated tests for the issue?
• If I have text, did I make it translatable and add a key in the English locale file(s)?
• Have I tested the changes (manually)?
  • Are all unit tests still passing? (npm run test)
• Are the changes visual?
  • Have I provided screenshots/videos of the changes?

[torranx]

stopped reviewing after seeing a lot of TODOs, maybe place this in draft for now if its not ready for review - or do you intend them to be in a separate PR?

[torranx]

also is there a reason why this is not using MoveRestrictionBattlerTag? How does this implementation interact with moves like Disable and Throat Chop? nvm saw the tests

[Bertie690]

stopped reviewing after seeing a lot of TODOs, maybe place this in draft for now if its not ready for review - or do you intend them to be in a separate PR?

My thought is that those fixes can probably go in a separate PR. This is partially implementing it after all!

also is there a reason why this is not using MoveRestrictionBattlerTag? How does this implementation interact with moves like Disable and Throat Chop?

Testing it again now, but the intended behavior is that Instruct itself will succeed but the called move will fail.

[torranx]

My thought is that those fixes can probably go in a separate PR. This is partially implementing it after all!

no problem 👍

Testing it again now, but the intended behavior is that Instruct itself will succeed but the called move will fail.
Torment is a special case: it should prevent move selection but not move execution.

ok so I've misunderstood the move, re-read the move description and watched some clips - MoveRestrictionBattlerTag is not the way to go yes: here's a detailed yt video on the move's mechanics.

(mb messed up and edited your comment instead of quote-replying- hope I put it back right)

[DayKev]

Found an issue where because Instruct was causing the Pokémon to use 2 moves in a single turn, the firstHit value was false in MoveEffectPhase for the second move when it shouldn't be. I fixed it for when the Instruct user moves after the target in the same turn, but the issue will still happen if the Instruct user moves first. Still need to look into that scenario.

Also fixed up the tests.

Since there were too many changes to reasonably use GitHub's suggestions feature, I made a PR instead: Bertie690#1

[Bertie690]

Since there were too many changes to reasonably use GitHub's suggestions feature, I made a PR instead: Bertie690#1

Cool. When do you want me to merge it?
(I'd presume by your earlier part of the message that the bug isn't 100% fixed yet)

[MokaStitcher]

@Bertie690 what's the status on the locale PR for this one? Seems like it's still marked as draft

[Bertie690]

AFAIK, it seems the non-English locale keys haven't been added yet.

[MokaStitcher]

AFAIK, it seems the non-English locale keys haven't been added yet.

Well yes, since the PR for the English key is still in draft there is no chance translations have been done. Why is it in draft is my question, is it not ready and needed for this PR ? pagefaultgames/pokerogue-locales#47

edit: to clarify, the english PR needs to go in first before the translations can start happening with the dedicated tool

[MokaStitcher]

Sorry for the accidental closure of the PR 💀