Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI/UX] New version of the 0 (zero) of pokemon-emerald-pro font #5167

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

Adri1
Copy link
Contributor

@Adri1 Adri1 commented Jan 22, 2025

What are the changes the user will see?

The way the "0" (zero) looks

Why am I making these changes?

To have a clear diffrence between the letter "O" and "0" (zero) + because the previous proposition wasn't popular

What are the changes from a developer perspective?

None

Screenshots/Videos

NEW PROPOSITION:
image

PREVIOUS EDIT:
image

How to test the changes?

Just play the game in places where it displays numbers

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • Has a locales PR been created on the locales repo?
    • If so, please leave a link to it here:
  • Has the translation team been contacted for proofreading/translation?

@Adri1 Adri1 added the UI/UX User interface/-experience related label Jan 22, 2025
@Adri1 Adri1 requested a review from a team as a code owner January 22, 2025 17:36
@Adri1 Adri1 changed the title [UI/UX] New version of the zero of pokemon-emerald-pro font [UI/UX] New version of the 0 (zero) of pokemon-emerald-pro font Jan 22, 2025
@damocleas damocleas merged commit 134c6e9 into pagefaultgames:beta Jan 22, 2025
13 checks passed
@Adri1 Adri1 deleted the zero-emerald-font-correction branch January 22, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX User interface/-experience related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants