Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Bug] Fix miniblackhole" #5183

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Revert "[Bug] Fix miniblackhole" #5183

merged 1 commit into from
Jan 25, 2025

Conversation

damocleas
Copy link
Collaborator

Reverts #5169

@damocleas damocleas marked this pull request as ready for review January 25, 2025 21:49
@damocleas damocleas requested a review from a team as a code owner January 25, 2025 21:49
@DayKev
Copy link
Collaborator

DayKev commented Jan 25, 2025

Was there a bug?
Ah, just saw the comment in the original PR.

@Snailman11
Copy link
Collaborator

Is the block of code working as intended?

@Blitz425
Copy link
Contributor

Hard agree on this revert, a fundamental change affecting the reoccurring big boss shouldn't be a last minute addition when update is soon.

@EscaShark
Copy link
Contributor

Is the block of code working as intended?

In Xav's PR, yes, it is working "as intended". But the problem is that this is what was "intended" a loooong time ago and, in the opinion of the majority of balance team members that have spoken up about it, not a good thing for the game right now. Ergo the existence of the bug is actually better for the game. This is also reflected in the bugfix receiving nothing but negative feedback from players.

Down the line the bugged block of code should probably be removed altogether, unless consensus on this issue were to flip. But as for now I'd rather have ugly code than code that does something neither the playerbase nor the balance team intends to happen.

@DayKev DayKev merged commit 706a232 into beta Jan 25, 2025
13 checks passed
@DayKev DayKev deleted the revert-5169-mbh-fix branch January 25, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants