Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sprite][Exp First batch of exp change #5231

Open
wants to merge 4 commits into
base: beta
Choose a base branch
from

Conversation

Unicornpowerstar
Copy link
Contributor

@Unicornpowerstar Unicornpowerstar commented Feb 1, 2025

  • Exp change to the Smogon approved once batch 1 of many
    This batch Includes : Tyrunt, Tyrantrum, Sylveon, Dedenne, Bergmite and Avalugg.

  • Screenshots and new animation found at the bottom. ( only shown for the mons with json changes )

  • old exp wont be shown as its not up to debate if it needs to be changed it
    must be changed.

When the link to this PR is linked all files have been tested once again and were found working.

Mons that got more then just Exp change

  • Tyrunt and Tyrantrum got sprite fix and variant Json file adjusted.
  • Sylveon only had Variant json adjusted.
  • Dedenne got the same sprite fix and copied the static variant json to the exp variant Json.

What are the changes the user will see?

Better Animation thats Smoother as well.

Why am I making these changes?

Reasons why the Exp change batch started was to deal with the backfill of outdated exps for mons.

What are the changes from a developer perspective?

Not much has changed other then new exps that are sorted and labled correctly.

How to test the changes?

Using said mons.

Checklist

  • I'm using beta as my base branch

  • The PR is self-contained and cannot be split into smaller PRs?

  • Have I tested the changes manually?

  • Are all unit tests still passing? (npm run test)

  • Have I provided screenshots/videos of the changes (if applicable)?

Screenshots

  • Tyrunt
The new animation

696-export-for-PR

Shiny tier 1

image1ish

Shiny tier 2

image ish

Shiny tier 3

image ishs

  • Tyrauntrum
New animation

697-gif-export

shiny tier 1

Screenshot 2025-02-01 151313

shiny tier 2

Screenshot 2025-02-01 151425

shiny tier 3

Screenshot 2025-02-01 151504

  • Sylveon
New animation

700-export

shiny tier 1

imagesihagj

shiny tier 2

imageaegaga

shiny tier 3

imageaegwg

  • Dedenne
New animation

702-export

shiny tier 1

Screenshot 2025-02-01 154719

shiny tier 2

Screenshot 2025-02-01 154617

shiny tier 3

Screenshot 2025-02-02 185419

  • Bergmite
New animation

712-export

shiny tier 1

Screenshot 2025-02-01 154816

( didnt need json adjusted since all colors were the same )
  • Avalugg
New animation

713-export

shiny tier 1

Screenshot 2025-02-01 154849

( didnt need json adjusted since all colors were the same )
  • If you still want the old exp and the variants that wasnt shown to be displayed contact me and Ill provide them here

@Unicornpowerstar Unicornpowerstar requested a review from a team as a code owner February 1, 2025 13:50
@Unicornpowerstar Unicornpowerstar self-assigned this Feb 2, 2025
@Unicornpowerstar Unicornpowerstar added the Sprite/Animation For issues/PRs related to graphics label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprite/Animation For issues/PRs related to graphics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants