Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Adding warning message for the maintenance #5263

Merged
merged 20 commits into from
Feb 7, 2025

Conversation

Wlowscha
Copy link
Contributor

@Wlowscha Wlowscha commented Feb 6, 2025

Displaying a message on the title page with starting and ending times (as dynamic dates) of the maintenance.

This is to warn users who don't have access or simply do not follow the discord.

Localization is needed. Localized strings will be directly added to title-ui-handler.ts without passing through locales.

Screenshots:

English

image

Spanish

image

Italian

image

French

image

German

image

Portugese (missing)

Chinese - Simplified

image

Chinese - Traditional

image

Korean

image

Japanese

image

This is meant as a quick fix to go online as soon as possible before the maintenance, as such it is rather clunky. We can change it later on to be more modular and customizable.

src/ui/title-ui-handler.ts Outdated Show resolved Hide resolved
@DayKev DayKev added the Miscellaneous Changes that don't fit under any other label label Feb 6, 2025
Copy link
Contributor

@Adri1 Adri1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

French Transaltion

src/ui/title-ui-handler.ts Outdated Show resolved Hide resolved
@DayKev
Copy link
Collaborator

DayKev commented Feb 6, 2025

Edit: Moved the textbox 10 pixels to the left, seems to have fixed it.

Textbox overlapping (old comment)

Textbox size needs to be adjusted:

image

Check for the language with the widest main menu box and use that for sizing.

Copy link
Contributor

@Adri1 Adri1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added zh-CN and zh-TW (provided by the Chinese translation team)

src/ui/title-ui-handler.ts Outdated Show resolved Hide resolved
src/ui/title-ui-handler.ts Outdated Show resolved Hide resolved
DayKev and others added 2 commits February 6, 2025 05:20
Co-authored-by: Lugiad' <[email protected]>
Co-authored-by: Lugiad' <[email protected]>
Copy link
Contributor

@Adri1 Adri1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Japanese

src/ui/title-ui-handler.ts Outdated Show resolved Hide resolved
Co-authored-by: Lugiad' <[email protected]>
Copy link
Contributor

@Adri1 Adri1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Spanish

src/ui/title-ui-handler.ts Outdated Show resolved Hide resolved
@DayKev
Copy link
Collaborator

DayKev commented Feb 6, 2025

Edit2: Updated Korean screenshot
Edit3: Add German, Italian; update Japanese. Re-do screenshots for remaining languages.
Added to main post.

English

image

Spanish

image

Italian

image

French

image

German

image

Portugese (missing)

Chinese - Simplified

image

Chinese - Traditional

image

Korean

image

Japanese

image

Copy link
Contributor

@Adri1 Adri1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added German

src/ui/title-ui-handler.ts Outdated Show resolved Hide resolved
@Wlowscha
Copy link
Contributor Author

Wlowscha commented Feb 6, 2025

annuncio italiano
jap_annoucement

Italian announcement and fixed weird box issues in japanese announcement

@damocleas damocleas marked this pull request as ready for review February 6, 2025 23:52
@damocleas damocleas requested a review from a team as a code owner February 6, 2025 23:52
Copy link
Collaborator

@damocleas damocleas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't seem like we're getting pt-BR in

@damocleas damocleas merged commit c88c933 into pagefaultgames:main Feb 7, 2025
14 checks passed
kille250 added a commit to moistdio/pokerogue that referenced this pull request Feb 7, 2025
[Hotfix] Adding warning message for the maintenance (pagefaultgames#5263)
DayKev added a commit that referenced this pull request Feb 8, 2025
patapancakes pushed a commit that referenced this pull request Feb 8, 2025
* Revert "[Hotfix] Adding warning message for the maintenance (#5263)"

This reverts commit c88c933.

* Update version to 1.5.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Miscellaneous Changes that don't fit under any other label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants