Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: P4PU-143 added secrets api key for biz-events service #4

Merged
merged 2 commits into from
May 28, 2024

Conversation

Giuseppe-LaManna
Copy link
Collaborator

List of Changes

  • added secrets

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Giuseppe-LaManna Giuseppe-LaManna requested a review from a team as a code owner May 28, 2024 10:29
@Giuseppe-LaManna Giuseppe-LaManna changed the title chore: [P4PU-143] added secrets api key for biz-events service chore: P4PU-143 added secrets api key for biz-events service May 28, 2024
@@ -16,3 +16,5 @@ management:
exposure.include: "*"
web:
exposure.include: info, health

api.key.biz.events: ${BIZ_EVENTS_SERVICE_API_KEY:}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need this deep structure. api-key and biz-events should not be separated

@and-mora and-mora merged commit c339e34 into develop May 28, 2024
3 checks passed
@and-mora and-mora deleted the P4PU-143-inserire-secret-su-helm-chart branch May 28, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants