fix: try with env

pagopa · Feb 3, 2025 · fdb32a8 · fdb32a8
1 parent fd7e88c
commit fdb32a8
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/.github/actions/get-pre-commit-version/action.yaml b/.github/actions/get-pre-commit-version/action.yaml
@@ -8,10 +8,12 @@ inputs:
 outputs:
   pre_commit_terraform_version:
     description: "The pre-commit-terraform version retrieved or the default."
+    value: ${{ steps.get-version.outputs.pre_commit_terraform_version }}
 runs:
   using: "composite"
   steps:
     - name: Get Pre-Commit Terraform Version
+      id: get-version
       shell: bash
       run: |
         # Default version from input
@@ -39,5 +41,10 @@ runs:
           fi
         fi
 
-        # Output the pre-commit Terraform version
-        echo "pre_commit_terraform_version=$PRE_COMMIT_VERSION" >> $GITHUB_OUTPUT
+        # Save to GITHUB_ENV first (correct for composite actions)
+        echo "pre_commit_terraform_version=$PRE_COMMIT_VERSION" >> "$GITHUB_ENV"
+
+    - name: Set Output
+      id: set-output
+      shell: bash
+      run: echo "pre_commit_terraform_version=${{ env.pre_commit_terraform_version }}" >> "$GITHUB_OUTPUT"
diff --git a/.github/actions/get-terraform-version/action.yaml b/.github/actions/get-terraform-version/action.yaml
@@ -8,10 +8,12 @@ inputs:
 outputs:
   terraform_version:
     description: "The Terraform version retrieved or the default."
+    value: ${{ steps.get-version.outputs.terraform_version }}
 runs:
   using: "composite"
   steps:
     - name: Get Terraform Version
+      id: get-version  # Needed to expose outputs in composite actions!
       shell: bash
       run: |
         # Default version provided via input
@@ -34,5 +36,9 @@ runs:
             echo "No .terraform-version file found. Defaulting to ${TERRAFORM_VERSION}"
         fi
         
-        # Output the Terraform version
-        echo "terraform_version=$TERRAFORM_VERSION" >> $GITHUB_OUTPUT
+        # Correct way to set outputs in composite actions
+        echo "terraform_version=$TERRAFORM_VERSION" >> "$GITHUB_ENV"
+    - name: Set Output
+      id: set-output
+      shell: bash
+      run: echo "terraform_version=${{ env.terraform_version }}" >> "$GITHUB_OUTPUT"