Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#CES-613] Autoscaler support shared App Service Plan #190

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

BurnedMarshal
Copy link
Contributor

List of changes

Can be provided a list of services to an autoscaler definition.
Requests scale settings are generated for each resource using the same App Service Plan

Motivation and context

Team require to use a single App Service Plan to more services. The autoscale have metrics linked to App Service Plan like CPU, but other metrics are available on single services attached to it, like requests.
We need to creare request scale rules based on each service.

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Other information

Copy link

changeset-bot bot commented Dec 13, 2024

⚠️ No Changeset found

Latest commit: 6eca047

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@BurnedMarshal BurnedMarshal force-pushed the CES-613-shared-appservice-autoscaler branch from f40f048 to 54171d6 Compare December 13, 2024 14:13
@BurnedMarshal BurnedMarshal force-pushed the CES-613-shared-appservice-autoscaler branch from f935b43 to 5954440 Compare December 13, 2024 15:41
@BurnedMarshal BurnedMarshal force-pushed the CES-613-shared-appservice-autoscaler branch from 5954440 to 3febf8d Compare December 13, 2024 15:42
@gunzip
Copy link
Contributor

gunzip commented Jan 31, 2025

is this still relevant @BurnedMarshal ?

@BurnedMarshal
Copy link
Contributor Author

is this still relevant @BurnedMarshal ?

Yes, this PR complete the support for Autoscaler Settings plan on shared App Service Plan. Without it teams need to redefine the autoscaler outside the shared plan like here
The PR require a fix on static analysis. cc. @Krusty93

@BurnedMarshal BurnedMarshal changed the title [#CES-613] Autoscaler support shared App Service Plan [#CES-613] Autoscaler support shared App Service Plan Feb 6, 2025
@BurnedMarshal BurnedMarshal marked this pull request as ready for review February 7, 2025 09:54
@BurnedMarshal BurnedMarshal requested a review from a team as a code owner February 7, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants