-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align Host and Worker sample rate in Azure Functions module AI tracing #252
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 7bcd11c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Danilo Spinelli <[email protected]>
Co-authored-by: Danilo Spinelli <[email protected]>
N.B. If the changes will be approved, they should be backported in these other modules:
|
Only in |
I'm unsure about the 'patch' changeset since this wil require a restart once applied. Maybe it would be better to use a major release? |
@gunzip In my opinion, this qualifies as a Are you assuming that the reference to this Terraform module follows the pattern From this module's perspective, it’s simply a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
This pull request aims to align the sample rate settings for both the Host and Worker in the Azure Functions module's AI tracing. The changes ensure consistency and potentially improve the reliability of Application Insights sampling.