Pull Request guidelines

[kin0992]

Introduce guidelines for managing pull requests to promote clarity and consistency.
Following these guidelines will help streamline the review process and improve communication within the team

Closes #CES-758

[changeset-bot]

🦋 Changeset detected

Latest commit: 2079afc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
docs	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[gunzip]

what about adding a line about the discouraged usage of conventional commits

[kin0992]

I will move the git and code-review changes, introduced into this PR, in a different PR because are out of scope here.

So, please, ignore them or acknowledge that any proposed change will not be part of this PR.

[gunzip]

what about a section about merge queues?

[kin0992]

what about a section about merge queues?

@gunzip I added a page related to the auto merge

[gunzip]

@gunzip I added a page related to the auto merge

@kin0992 are auto-merge and merge-queue related someway? afaik they're different features for different use cases.

[kin0992]

@gunzip I added a page related to the auto merge

@kin0992 are auto-merge and merge-queue related someway? afaik they're different features for different use cases.

you are right @gunzip, I wrongly assumed you meant the auto merge, since it is something we already use. Indeed auto merge and merge queue are different. It may not be useful for us and, for now, I'd keep in the guideline the information about the auto merge only.
Could we add a separate task to evaluate the use of merge queue and then, if we decide to adopt it, update the guideline? What do you think?

[gunzip]

Could we add a separate task to evaluate the use of merge queue and then, if we decide to adopt it, update the guideline? What do you think?

Agree.

[kin0992]

Could we add a separate task to evaluate the use of merge queue and then, if we decide to adopt it, update the guideline? What do you think?

Agree.

@gunzip Tracked with CES-782

[lucacavallaro]

@gunzip @kin0992 disabling merge-queue will free us to unlink PR description and PR commit body, enabling a more descriptive PR with screenshot, examples, etc.

[manuraf]

Is there any Github Action that verifies these guidelines, or will you provide one? .... At wallet team we have some workflows that for ex. check PR title or if it has a reference to JIRA task