redis first impl

pagopa · Jan 20, 2025 · 862400c · 862400c
1 parent a99932b
commit 862400c
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 10 deletions.
diff --git a/src/main/java/it/gov/pagopa/onboarding/citizen/controller/CitizenControllerImpl.java b/src/main/java/it/gov/pagopa/onboarding/citizen/controller/CitizenControllerImpl.java
@@ -73,10 +73,7 @@ public Mono<ResponseEntity<CitizenConsentDTO>> deleteCitizenConsent(String fisca
     @Override
     public Mono<ResponseEntity<String>> bloomFilterSearch(String fiscalCode) {
         return bloomFilterService.mightContain(fiscalCode)
-                .map(response -> response
-                        ? ResponseEntity.ok("OK")
-                        : ResponseEntity.status(HttpStatus.ACCEPTED).body("NO CHANNELS ENABLED")
-                );
+                .map(result -> ResponseEntity.ok().body(result));
     }
 
 }
diff --git a/src/main/java/it/gov/pagopa/onboarding/citizen/service/BloomFilterService.java b/src/main/java/it/gov/pagopa/onboarding/citizen/service/BloomFilterService.java
@@ -4,5 +4,5 @@
 
 public interface BloomFilterService {
 
-     Mono<Boolean> mightContain(String hashedFiscalCode);
+     Mono<String> mightContain(String hashedFiscalCode);
 }
diff --git a/src/main/java/it/gov/pagopa/onboarding/citizen/service/BloomFilterServiceImpl.java b/src/main/java/it/gov/pagopa/onboarding/citizen/service/BloomFilterServiceImpl.java
@@ -50,11 +50,24 @@ private RBloomFilterReactive<String> initializeBloomFilter(RedissonReactiveClien
     }
 
     public void add(String value) {
-        bloomFilter.add(value);
+        bloomFilter.add(value).doOnSuccess(result -> {
+            if(result)
+                log.info("[BLOOM-FILTER-SERVICE] Fiscal Code added to bloom filter");
+            else
+                log.info("[BLOOM-FILTER-SERVICE] Fiscal Code not added to bloom filter");
+        })
+        .subscribe();
     }
 
-    public Mono<Boolean> mightContain(String value) {
-        return bloomFilter.contains(value);
+    public Mono<String> mightContain(String value) {
+        return bloomFilter.contains(value).map(result -> {
+            if (Boolean.TRUE.equals(result)) {
+                log.info("[BLOOM-FILTER-SERVICE] Fiscal Code found");
+                return "OK";
+            } else {
+                log.info("[BLOOM-FILTER-SERVICE] Fiscal Code not found");
+                return "NO CHANNELS ENABLED";
+            }
+        });
     }
-
 }
diff --git a/src/main/java/it/gov/pagopa/onboarding/citizen/service/CitizenServiceImpl.java b/src/main/java/it/gov/pagopa/onboarding/citizen/service/CitizenServiceImpl.java
@@ -85,7 +85,8 @@ public Mono<CitizenConsentDTO> createCitizenConsent(String fiscalCode, String tp
                             return citizenRepository
                                     .save(citizenConsentToSave)
                                     .map(mapperToDTO::map)
-                                    .doOnSuccess(citizenConsentSaved -> bloomFilterService.add(fiscalCode));
+                                    .doOnSuccess(citizenConsentSaved -> bloomFilterService.add(fiscalCode)
+                                    );
                         }))
                 )
                 .doOnSuccess(savedConsent ->