PIN 6325 - Update eservice instance descriptor #1612
+981
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalpenZibo
force-pushed
the
PIN-6325_update-eservice-instance-descriptor
branch
from
fa8458c to
cff4175
Compare
MalpenZibo
requested review from
beetlecrunch,
galales,
AsterITA,
Carminepo2 and
taglioni-r
as code owners
ecamellini
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
The same comments I left on #1610 apply here as well (minor stuff)
Comment on lines
1362
to
1363
| // Descriptor in state WaitingForApproval can be updated | ||
| if (descriptor.state !== descriptorState.draft) { |
There was a problem hiding this comment.
The comment says that descriptors in WaitingForApproval can be updated, but the check allows only Draft descriptors. Maybe the comment is not needed?
(I see a similar comment in many methods of this file, with the same contradiction - could you remove it everywhere?)
ecamellini
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PIN-6325