-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(IDPay): [IOBP-1139] Add new IDPay initiative reward type EXPENSE
#6621
Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6621 +/- ##
=======================================
Coverage 50.04% 50.04%
=======================================
Files 1539 1539
Lines 32170 32187 +17
Branches 7295 7251 -44
=======================================
+ Hits 16100 16109 +9
- Misses 16019 16040 +21
+ Partials 51 38 -13
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
EXPENSE
EXPENSE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
…ils screen (#6622) ##⚠️ This PR depends on #6621⚠️ ## Short description This PR adds the "Chiedi aiuto" call-to-action within the beneficiary details screen. By clicking this CTA, a support ticket is automatically created with the preselected category and subcategory, so the user is not prompted to choose them manually. ## List of changes proposed in this pull request - Added the `assistanceForIdPay` flag that if it's true, it doesn't prompt the user choosing the category manually but it will be preselected; - Created a custom hook `useIdPaySupportModal` that shows the zendesk support modal and pre-select the category and subcategory for that screen; ## How to test - Checkout the dev-server from this PR: pagopa/io-dev-api-server#457; - Run `yarn sync`; - Go inside the expense initiative detail and tap on the info icon on the top right corner of the screen; - Check that there is available a `Chiedi aiuto` call-to-action that shows a modal with the FAQ; - Check that if you tap on the button "Open a support request", it doesn't prompt to the user to select the category of the topic; ## Preview https://github.com/user-attachments/assets/7255110d-1f88-4420-b4af-01bab44030ec --------- Co-authored-by: Emanuele Dall'Ara <[email protected]>
Short description
This PR introduces a new IDPay initiative reward of type EXPENSE. This kind of initiative will enable citizens to receive refunds by submitting a fiscal receipt through a separate FIMS flow. The goal of this PR only covers the management of the initiative’s detail view and its timeline.
N.B: The
Chiedi aiuto
CTA will be implemented in another PR.List of changes proposed in this pull request
BeneficiaryDetails
screen for this new kind of initiative type;How to test
yarn sync
;[E]
that indicates an initiative of typeEXPENSE
;Preview
preview.mov