Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOCOM-2086] addition of SEND banner to payload #469

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

forrest57
Copy link
Contributor

Short description

addition of said banner's ID to the payloads object

List of changes proposed in this pull request

  • addition of banner ID

How to test

when checking out this PR: pagopa/io-app#6756

after enabling the banner in app, it should correctly render in the second place.

Copy link
Contributor

@Vangaorth Vangaorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@forrest57 forrest57 merged commit c2c65d4 into master Feb 25, 2025
3 checks passed
@forrest57 forrest57 deleted the IOCOM-2086-SEND-banner branch February 25, 2025 16:29
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.97%. Comparing base (0f932a0) to head (7fa808b).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #469   +/-   ##
=======================================
  Coverage   63.97%   63.97%           
=======================================
  Files         164      164           
  Lines        5346     5349    +3     
  Branches      703      708    +5     
=======================================
+ Hits         3420     3422    +2     
- Misses       1925     1926    +1     
  Partials        1        1           
Files with missing lines Coverage Δ
src/payloads/backend.ts 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4c22a8...7fa808b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants