Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update landing_banners.priority_order list #470

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

ChrisMattew
Copy link
Collaborator

Short description

This PR removes the SETTINGS_DISCOVERY value from the landing banners priority order configuration list

@ChrisMattew ChrisMattew requested review from gispada, freddi301 and a team as code owners February 26, 2025 11:47
@ChrisMattew ChrisMattew self-assigned this Feb 26, 2025
@ChrisMattew ChrisMattew added the IO-A&I IO - Autenticazione e Identità label Feb 26, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.95%. Comparing base (7fa808b) to head (90d746c).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
- Coverage   63.97%   63.95%   -0.02%     
==========================================
  Files         164      164              
  Lines        5349     5349              
  Branches      708      708              
==========================================
- Hits         3422     3421       -1     
+ Misses       1926     1784     -142     
- Partials        1      144     +143     
Files with missing lines Coverage Δ
src/payloads/backend.ts 100.00% <ø> (ø)

... and 34 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2c65d4...90d746c. Read the comment docs.

Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Ladirico Ladirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shadowsheep1 shadowsheep1 merged commit 0c21569 into master Mar 5, 2025
6 checks passed
@shadowsheep1 shadowsheep1 deleted the IOPID-2671 branch March 5, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-A&I IO - Autenticazione e Identità
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants