fix: Debt-position-status-checker (#23)

src/main/java/it/gov/pagopa/pu/debtpositions/service/statusalign/StatusRulesHandler.java

@@ -53,10 +53,7 @@ public boolean isToSync(List<E> childrenStatusList) {
     return childrenStatusList.contains(syncStatus);
   }
 
-  public boolean isPartiallyPaid(List<E> childrenStatusList) {
-    return childrenStatusList.contains(paidStatus) &&
-      (childrenStatusList.contains(unpaidStatus) || childrenStatusList.contains(expiredStatus));
-  }
+  protected abstract boolean isPartiallyPaid(List<E> childrenStatusList);
 
   public boolean isUnpaid(List<E> childrenStatusList) {
     return allMatch(childrenStatusList, unpaidStatus, allowedCancelledStatuses);

src/main/java/it/gov/pagopa/pu/debtpositions/service/statusalign/debtposition/DebtPositionStatusChecker.java

@@ -44,6 +44,12 @@ public DebtPositionStatus calculateNewStatus(List<PaymentOptionStatus> paymentOp
     }
   }
 
+  @Override
+  public boolean isPartiallyPaid(List<PaymentOptionStatus> childrenStatusList) {
+    return childrenStatusList.contains(PARTIALLY_PAID);
+  }
+
+
   @Override
   protected List<PaymentOptionStatus> getChildStatuses(DebtPosition debtPosition) {
     return debtPosition.getPaymentOptions().stream()

src/main/java/it/gov/pagopa/pu/debtpositions/service/statusalign/paymentoption/PaymentOptionStatusChecker.java

@@ -61,4 +61,10 @@ protected void setStatus(PaymentOption paymentOption, PaymentOptionStatus newSta
   protected void storeStatus(PaymentOption paymentOption, PaymentOptionStatus newStatus) {
     paymentOptionRepository.updateStatus(paymentOption.getPaymentOptionId(), newStatus);
   }
+
+  @Override
+  protected boolean isPartiallyPaid(List<InstallmentStatus> childrenStatusList) {
+    return childrenStatusList.contains(InstallmentStatus.PAID) &&
+      (childrenStatusList.contains(InstallmentStatus.UNPAID) || childrenStatusList.contains(InstallmentStatus.EXPIRED));
+  }
 }

src/test/java/it/gov/pagopa/pu/debtpositions/service/statusalign/debtposition/DebtPositionStatusCheckerTest.java

@@ -44,21 +44,11 @@ void testCalculateNewStatus_ToSync() {
   }
 
   /**
-   * Test if the status is PARTIALLY_PAID when there is at least one PAID and one UNPAID paymentOption.
+   * Test if the status is PARTIALLY_PAID when there is at least one PARTIALLY_PAID paymentOption.
    */
   @Test
-  void testCalculateNewStatus_PartiallyPaid() {
-    List<PaymentOptionStatus> paymentOptionStatusList = List.of(PaymentOptionStatus.PAID, PaymentOptionStatus.UNPAID);
-    DebtPositionStatus result = checker.calculateNewStatus(paymentOptionStatusList);
-    assertEquals(DebtPositionStatus.PARTIALLY_PAID, result);
-  }
-
-  /**
-   * Test if the status is PARTIALLY_PAID when there is at least one PAID and one EXPIRED paymentOption.
-   */
-  @Test
-  void testDeterminePaymentOptionStatus_PartiallyPaid2() {
-    List<PaymentOptionStatus> paymentOptionStatusList = List.of(PaymentOptionStatus.PAID, PaymentOptionStatus.EXPIRED);
+  void testDeterminePaymentOptionStatus_PartiallyPaid() {
+    List<PaymentOptionStatus> paymentOptionStatusList = List.of(PaymentOptionStatus.EXPIRED, PaymentOptionStatus.PARTIALLY_PAID);
     DebtPositionStatus result = checker.calculateNewStatus(paymentOptionStatusList);
     assertEquals(DebtPositionStatus.PARTIALLY_PAID, result);
   }