fix: P4ADEV-2023-fix-finalize-sync-status-dp (#39)

pagopa · Jan 30, 2025 · b97c4fc · b97c4fc
1 parent ad9e24f
commit b97c4fc
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/src/main/java/it/gov/pagopa/pu/debtpositions/repository/InstallmentNoPIIRepository.java b/src/main/java/it/gov/pagopa/pu/debtpositions/repository/InstallmentNoPIIRepository.java
@@ -18,7 +18,7 @@ public interface InstallmentNoPIIRepository extends JpaRepository<InstallmentNoP
   @RestResource(exported = false)
   @Transactional
   @Modifying
-  @Query("UPDATE InstallmentNoPII i SET i.status = :status, i.iupdPagopa = :iupdPagopa WHERE i.installmentId = :installmentId")
+  @Query("UPDATE InstallmentNoPII i SET i.status = :status, i.iupdPagopa = :iupdPagopa, i.syncStatus = NULL WHERE i.installmentId = :installmentId")
   void updateStatusAndIupdPagopa(@Param("installmentId") Long installmentId, @Param("iupdPagopa") String iupdPagopa, @Param("status") InstallmentStatus status);
 
   @RestResource(exported = false)

diff --git a/...a/pu/debtpositions/service/statusalign/DebtPositionHierarchyStatusAlignerServiceImpl.java b/...a/pu/debtpositions/service/statusalign/DebtPositionHierarchyStatusAlignerServiceImpl.java
@@ -67,6 +67,7 @@ public DebtPositionDTO finalizeSyncStatus(Long debtPositionId, Map<String, IupdS
 
           InstallmentStatus newStatus = updateDTO.getNewStatus();
           installment.setStatus(newStatus);
+          installment.setSyncStatus(null);
           log.info("Updating status {} and iupdPagopa {} for installment with id {}", newStatus, updateDTO.getIupdPagopa(), installment.getInstallmentId());
           installmentNoPIIRepository.updateStatusAndIupdPagopa(
             installment.getInstallmentId(),

diff --git a/...a/pu/debtpositions/service/statusalign/DebtPositionHierarchyStatusAlignerServiceTest.java b/...a/pu/debtpositions/service/statusalign/DebtPositionHierarchyStatusAlignerServiceTest.java
@@ -60,21 +60,22 @@ void givenFinalizeSyncStatusThenOk() {
     Mockito.doNothing().when(installmentNoPIIRepositoryMock).updateStatusAndIupdPagopa(id, iupdPagoPa, newStatus);
     Mockito.doNothing().when(paymentOptionInnerStatusAlignerServiceMock).updatePaymentOptionStatus(buildPaymentOption());
     Mockito.doNothing().when(debtPositionInnerStatusAlignerServiceMock).updateDebtPositionStatus(debtPosition);
-    Mockito.when(debtPositionMapperMock.mapToDto(debtPosition)).thenReturn(buildDebtPositionDTO());
+    DebtPositionDTO debtPositionDTO = buildDebtPositionDTO();
+    debtPositionDTO.getPaymentOptions().getFirst().getInstallments().getFirst().syncStatus(null);
+    Mockito.when(debtPositionMapperMock.mapToDto(debtPosition)).thenReturn(debtPositionDTO);
 
-    Map<String, IupdSyncStatusUpdateDTO> syncStatusDTO = new HashMap<>();
-    IupdSyncStatusUpdateDTO iupdSyncStatusUpdateDTO = IupdSyncStatusUpdateDTO.builder()
+    Map<String, IupdSyncStatusUpdateDTO> syncStatusDTO = Map.of("iud", IupdSyncStatusUpdateDTO.builder()
       .newStatus(newStatus)
       .iupdPagopa(iupdPagoPa)
-      .build();
+      .build());
 
-    syncStatusDTO.put("iud", iupdSyncStatusUpdateDTO);
     DebtPositionDTO result = service.finalizeSyncStatus(id, syncStatusDTO);
 
     assertEquals(DebtPositionStatus.UNPAID, result.getStatus());
     assertEquals(PaymentOptionStatus.UNPAID, result.getPaymentOptions().getFirst().getStatus());
     assertEquals(InstallmentStatus.UNPAID, result.getPaymentOptions().getFirst().getInstallments().getFirst().getStatus());
-    reflectionEqualsByName(buildDebtPositionDTO(), result);
+    assertNull(result.getPaymentOptions().getFirst().getInstallments().getFirst().getSyncStatus());
+    reflectionEqualsByName(debtPositionDTO, result);
   }
 
   @Test