Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: P4ADEV-1779 create api get installments by organization id and nav #30

Merged
merged 15 commits into from
Jan 27, 2025
Merged

feat: P4ADEV-1779 create api get installments by organization id and nav #30

merged 15 commits into from
Jan 27, 2025

Conversation

serdimic
Copy link
Collaborator

Description

create api getInstallmentsByOrganizationIdAndNav

List of Changes

create api getInstallmentsByOrganizationIdAndNav

Motivation and Context

neede for implementation of pagopa-payments paSendRT

How Has This Been Tested?

  • Pre-Deploy Test
    • Unit
    • Integration (Narrow)
  • Post-Deploy Test
    • Isolated Microservice
    • Broader Integration
    • Acceptance
    • Performance & Load

Types of changes

  • PATCH - Bug fix (backwards compatible bug fixes)
  • MINOR - New feature (add functionality in a backwards compatible manner)
  • MAJOR - Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CHORE - Minor Change (fix or feature that don't impact the functionality e.g. Documentation or lint configuration)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

serdimic added 11 commits January 27, 2025 14:39
@serdimic
P4ADEV-1779 modify handling of NotFoundException on ExceptionHandler
23fee88
@serdimic
P4ADEV-1779 add NoPII filed on InstallmentPIIMapper.map()
faaff19
@serdimic
P4ADEV-1779 add test for InstallmentMapper.mapToDto()
a816240
@serdimic
P4ADEV-1779 improve TestUtils.reflectionEqualsByName (support collect…
e257ff0 
…ions, arrays, generic date/time)
@serdimic
P4ADEV-1779 update generated.openapi.json
18d48f6
@serdimic
P4ADEV-1779 use faker to generate mock installment data
78d6ed8
@serdimic
P4ADEV-1779 remove podam dependency
ded8bbd
@serdimic
Merge branch 'develop' into P4ADEV-1779-create_api_getInstallmentsByO…
9b6912c 
…rganizationIdAndNav
@serdimic
P4ADEV-1779 update generated.openapi.json
9e74e5d
@serdimic
P4ADEV-1779 update installment mappers for syncStatus field
f07bbe2
@serdimic
P4ADEV-1779 rollback remove podam dependency (still used in some cont…
90c32f7 
…ext)
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@serdimic serdimic merged commit 4ecaed3 into develop Jan 27, 2025
11 checks passed
@serdimic serdimic deleted the P4ADEV-1779-create_api_getInstallmentsByOrganizationIdAndNav branch January 27, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonioT90 antonioT90 antonioT90 approved these changes

@antocalo antocalo Awaiting requested review from antocalo antocalo is a code owner

@Benedetta-fabbri Benedetta-fabbri Awaiting requested review from Benedetta-fabbri Benedetta-fabbri is a code owner

@LarissaASLeite LarissaASLeite Awaiting requested review from LarissaASLeite LarissaASLeite is a code owner

@RiccardoGiuliani RiccardoGiuliani Awaiting requested review from RiccardoGiuliani RiccardoGiuliani is a code owner

@oleksiybozhykntt oleksiybozhykntt Awaiting requested review from oleksiybozhykntt oleksiybozhykntt is a code owner

@ElisKina-dev ElisKina-dev Awaiting requested review from ElisKina-dev ElisKina-dev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serdimic @antonioT90