P4ADEV-1377 edit helm files and delete devops codereview

pagopa · Nov 14, 2024 · 877c555 · 877c555
1 parent c2c041e
commit 877c555
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 72 deletions.
diff --git a/.devops/code-review-pipelines.yml b/.devops/code-review-pipelines.yml
diff --git a/.github/workflows/security-scan.yml b/.github/workflows/security-scan.yml
@@ -62,7 +62,7 @@ jobs:
   SendSlackNotification:
     needs: BuildAndScan
     uses: ./.github/workflows/send-notification.yml
-    if: always() && needs.BuildAndScan.result == 'failure'
+    if: always() && (env.CVE_HIGH > 0 || env.CVE_CRITICAL > 0)
     with:
       CVE_CRITICAL: ${{needs.BuildAndScan.outputs.CVE_CRITICAL}}
       CVE_HIGH: ${{needs.BuildAndScan.outputs.CVE_HIGH}}

diff --git a/helm/Chart.yaml b/helm/Chart.yaml
@@ -1,6 +1,6 @@
 apiVersion: v2
-name: p4pa-pdnd
-description: P4PA PDND
+name: p4pa-pdnd-services
+description: P4PA PDND SERVICES
 type: application
 version: 1.0.0
 appVersion: 1.0.0

diff --git a/helm/values-dev.yaml b/helm/values-dev.yaml
@@ -1,6 +1,6 @@
 microservice-chart:
   image:
-    repository: p4paditncorecommonacr.azurecr.io/p4papdnd
+    repository: p4paditncorecommonacr.azurecr.io/p4papdndservices
     tag: latest
     pullPolicy: Always
 
@@ -31,10 +31,6 @@ microservice-chart:
     ENV: "DEV"
     JAVA_TOOL_OPTIONS: "-Xms128m -Xmx4g -Djava.util.concurrent.ForkJoinPool.common.parallelism=7 -javaagent:/app/applicationinsights-agent.jar -Dapplicationinsights.configuration.file=/mnt/file-config-external/appinsights-config/applicationinsights.json -agentlib:jdwp=transport=dt_socket,server=y,address=8001,suspend=n -Dcom.sun.management.jmxremote=true -Dcom.sun.management.jmxremote.port=3002 -Dcom.sun.management.jmxremote.rmi.port=3003 -Djava.rmi.server.hostname=127.0.0.1 -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false"
 
-    JWT_TOKEN_AUDIENCE: "dev.piattaformaunitaria.pagopa.it"
-    JWT_EXTERNAL_TOKEN_ISS: "https://dev.selfcare.pagopa.it"
-    JWT_EXTERNAL_TOKEN_BASE_URL: "https://dev.selfcare.pagopa.it"
-
   keyvault:
     name: "p4pa-d-payhub-kv"
     tenantId: "7788edaf-0346-4068-9d79-c868aed15b3d"
diff --git a/helm/values-prod.yaml b/helm/values-prod.yaml
@@ -1,6 +1,6 @@
 microservice-chart:
   image:
-    repository: p4papitncorecommonacr.azurecr.io/p4papdnd
+    repository: p4papitncorecommonacr.azurecr.io/p4papdndservices
     tag: latest
     pullPolicy: Always
 
@@ -31,10 +31,6 @@ microservice-chart:
     ENV: "PROD"
     JAVA_TOOL_OPTIONS: "-Xms128m -Xmx4g -Djava.util.concurrent.ForkJoinPool.common.parallelism=7 -javaagent:/app/applicationinsights-agent.jar -Dapplicationinsights.configuration.file=/mnt/file-config-external/appinsights-config/applicationinsights.json -agentlib:jdwp=transport=dt_socket,server=y,address=8001,suspend=n -Dcom.sun.management.jmxremote=true -Dcom.sun.management.jmxremote.port=3002 -Dcom.sun.management.jmxremote.rmi.port=3003 -Djava.rmi.server.hostname=127.0.0.1 -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false"
 
-    JWT_TOKEN_AUDIENCE: "piattaformaunitaria.pagopa.it"
-    JWT_EXTERNAL_TOKEN_ISS: "https://selfcare.pagopa.it"
-    JWT_EXTERNAL_TOKEN_BASE_URL: "https://selfcare.pagopa.it"
-
   keyvault:
     name: "p4pa-p-payhub-kv"
     tenantId: "7788edaf-0346-4068-9d79-c868aed15b3d"
diff --git a/helm/values-uat.yaml b/helm/values-uat.yaml
@@ -1,6 +1,6 @@
 microservice-chart:
   image:
-    repository: p4pauitncorecommonacr.azurecr.io/p4papdnd
+    repository: p4pauitncorecommonacr.azurecr.io/p4papdndservices
     tag: latest
     pullPolicy: Always
 
@@ -31,10 +31,6 @@ microservice-chart:
     ENV: "UAT"
     JAVA_TOOL_OPTIONS: "-Xms128m -Xmx4g -Djava.util.concurrent.ForkJoinPool.common.parallelism=7 -javaagent:/app/applicationinsights-agent.jar -Dapplicationinsights.configuration.file=/mnt/file-config-external/appinsights-config/applicationinsights.json -agentlib:jdwp=transport=dt_socket,server=y,address=8001,suspend=n -Dcom.sun.management.jmxremote=true -Dcom.sun.management.jmxremote.port=3002 -Dcom.sun.management.jmxremote.rmi.port=3003 -Djava.rmi.server.hostname=127.0.0.1 -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false"
 
-    JWT_TOKEN_AUDIENCE: "uat.piattaformaunitaria.pagopa.it"
-    JWT_EXTERNAL_TOKEN_ISS: "https://uat.selfcare.pagopa.it"
-    JWT_EXTERNAL_TOKEN_BASE_URL: "https://uat.selfcare.pagopa.it"
-
   keyvault:
     name: "p4pa-u-payhub-kv"
     tenantId: "7788edaf-0346-4068-9d79-c868aed15b3d"
diff --git a/helm/values.yaml b/helm/values.yaml
@@ -55,7 +55,7 @@ microservice-chart:
         key: applicationinsights.json
 
   envConfig:
-    APPLICATIONINSIGHTS_ROLE_NAME: "p4papdnd"
+    APPLICATIONINSIGHTS_ROLE_NAME: "p4papdndservices"
     APPLICATIONINSIGHTS_INSTRUMENTATION_LOGGING_LEVEL: "OFF"
     APPLICATIONINSIGHTS_INSTRUMENTATION_MICROMETER_ENABLED: "false"
     APPLICATIONINSIGHTS_PREVIEW_PROFILER_ENABLED: "false"