Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAGOPA-1481 fixing dockerfile for app insights #35

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

FedericoRuzzier
Copy link

@FedericoRuzzier FedericoRuzzier commented Feb 1, 2024

List of Changes

Changing dockerfile to log application insights

Motivation and Context

The old dockerfile was not working properly with application insights

How Has This Been Tested?

Manually

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@FedericoRuzzier FedericoRuzzier added the bug Something isn't working label Feb 1, 2024
Copy link

@cap-ang cap-ang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, check the comments I left

Dockerfile Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Copy link

@cap-ang cap-ang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, check the comments I left

Copy link

github-actions bot commented Feb 7, 2024

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@FedericoRuzzier FedericoRuzzier merged commit 37c6e76 into main Feb 7, 2024
6 of 8 checks passed
@FedericoRuzzier FedericoRuzzier deleted the PAGOPA-1481-sviluppo-upgrade-ai-with-java-17 branch February 7, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants