Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [PAGOPA-1455] migration to java 17 #201

Merged
merged 48 commits into from
Jan 25, 2024

Conversation

alessio-acitelli
Copy link
Collaborator

@alessio-acitelli alessio-acitelli commented Jan 16, 2024

List of Changes

  • update to java 17

Motivation and Context

  • sonar analysis has deprecated java 11

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

pagopa-github-bot and others added 27 commits January 16, 2024 17:13
aacitelli and others added 16 commits January 17, 2024 14:55
@alessio-acitelli alessio-acitelli marked this pull request as ready for review January 17, 2024 16:15
@alessio-acitelli alessio-acitelli requested a review from a team as a code owner January 17, 2024 16:15
Copy link
Contributor

@cap-ang cap-ang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions, anyway, LGTM 🔝

Dockerfile.deploy Outdated Show resolved Hide resolved
Dockerfile.test Outdated Show resolved Hide resolved
Copy link
Contributor

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

Copy link
Contributor

@FedericoRuzzier FedericoRuzzier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alessio-acitelli alessio-acitelli merged commit 15a9e57 into main Jan 25, 2024
5 of 7 checks passed
@alessio-acitelli alessio-acitelli deleted the PAGOPA-1455-migration-to-java17 branch January 25, 2024 09:13
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants