Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PAGOPA-2586] feat: GPD v3 - Add new debtor's fields to PaymentOption model #30

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[PAGOPA-2586] feat: GPD v3 - Add new debtor's fields to PaymentOption model #30

wants to merge 7 commits into from
+930 −676

Conversation

svariant
Copy link
Collaborator

@svariant svariant commented Jan 15, 2025 •
edited
Loading

List of Changes

Motivation and Context

PAGOPA-2586

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@svariant svariant added the minor label Jan 15, 2025
@svariant svariant changed the title [PAGOPA-2586] feat: Add new debtor's fields to PaymentOption model [PAGOPA-2586] feat: GPD v3 - Add new debtor's fields to PaymentOption model Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.4% Coverage on New Code
0.7% Duplication on New Code

See analysis details on SonarQube Cloud

@svariant svariant marked this pull request as ready for review January 16, 2025 11:00
pasqualespica
pasqualespica approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @gioelemella
Try & deploy it ( via branch ) in UAT and DEV env

@aferracci according to this PR , io open a new PR https://github.com/pagopa/eng-github-authorization/pull/1776

@pasqualespica pasqualespica added documentation Improvements or additions to documentation duplicate This issue or pull request already exists uat and removed duplicate This issue or pull request already exists labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@svariant svariant

Labels
documentation Improvements or additions to documentation minor size/large uat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svariant @pasqualespica @pagopa-github-bot