Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [PQ-257] add ebollo configuration to checkout policy apim #2668

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: [PQ-257] add ebollo configuration to checkout policy apim #2668

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d656f97
[PQ-257] add ebollo configuration to checkout policy apim
aferracci Dec 16, 2024
d2d1f0b
Merge branch 'main' into PQ-257-ebollo-client-id-checkout-policy
pasqualespica Dec 17, 2024
37c2047
Merge branch 'main' into PQ-257-ebollo-client-id-checkout-policy
infantesimone Dec 17, 2024
25ab570
[PQ-257] replaced when block with otherwise
aferracci Dec 17, 2024
f47da6c
Merge branch 'PQ-257-ebollo-client-id-checkout-policy' of https://git…
aferracci Dec 17, 2024
07dc3eb
Merge branch 'main' into PQ-257-ebollo-client-id-checkout-policy
infantesimone Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/domains/checkout-app/api/checkout/checkout_carts_auth/v1/_base_policy.xml.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@
<value>WISP_REDIRECT</value>
</set-header>
</when>
<when condition="@(context.Subscription != null && context.Subscription.Id.ToLower().Equals("ebollo"))">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to use otherwise, if there are exceptions or particular clients we will specify them. eBollo on ecommerce is tracked as CHECKOUT_CART

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@infantesimone as agreed the when block has been replaced with otherwise, there's no need to distinguish between ebollo payments and any other ones coming from EC.

cc @pietro-tota @pasqualespica

<set-header name="x-client-id" exists-action="override">
<value>CHECKOUT_CART</value>
</set-header>
</when>
<!-- add here handling for future api clients to be integrated, such as SEND -->
</choose>
</inbound>
Expand Down
Loading