chore(routing-policy): [CHK-3671] improve ecommerce routing policies performance #2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to startsWith to improve routing performance; add operationId to conditions to avoid potential ambiguity during routing;
dylantangredi-bvt
changed the title
CianoDanilo
reviewed
Feb 4, 2025
src/domains/ecommerce-app/api/ecommerce-checkout/v1/_base_policy.xml.tpl
Outdated
Show resolved
Hide resolved
replace local openapi paths and operationIds with APIM ones; revert conditions from startsWith to contains to prevent some urls from being excluded from routing correctly
scaminati-bv
previously approved these changes
Feb 5, 2025
src/domains/ecommerce-app/api/ecommerce-checkout/v1/_base_policy.xml.tpl
Outdated
Show resolved
Hide resolved
scaminati-bv
previously approved these changes
Feb 7, 2025
sfarralorenzo
previously approved these changes
Feb 10, 2025
CianoDanilo
previously approved these changes
Feb 10, 2025
pietro-tota
reviewed
Feb 11, 2025
src/domains/ecommerce-app/api/ecommerce-checkout/v1/_base_policy.xml.tpl
Outdated
Show resolved
Hide resolved
ciuffagianluca
dismissed stale reviews from scaminati-bv, sfarralorenzo, and CianoDanilo
via
8139c93
ciuffagianluca
requested review from
pietro-tota,
CianoDanilo,
sfarralorenzo and
scaminati-bv
CianoDanilo
approved these changes
Feb 11, 2025
sfarralorenzo
approved these changes
Feb 12, 2025
EmanueleBVtech
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
Motivation and context
The change was necessary to avoid potential ambiguity when routing by adding stricter conditions on operationIds
Type of changes
Does this introduce a change to production resources with possible user impact?
Does this introduce an unwanted change on infrastructure? Check terraform plan execution result
Other information
The backend urls will remain untouched (i.e. there will be no /v2 or /v2.1 set as endpoint based on the conditions). What will change are the conditions necessary for those existing base-urls to be set. For example, the pagopa-wallet-service will be the routing destination only if the operationId from the request is one of those specified in the relevant APIM openapi specifications file (there was no operationId discrimination before)
TESTS: tested after terraform apply on dev with checkout UI, Postman API calls and dev APIM calls.
Terraform targets:
If PR is partially applied, why? (reserved to mantainers)