Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA-5638 Miglioramento classe AvanzamentoNotificheWebhookB2bSteps #654

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

QA-5638 Miglioramento classe AvanzamentoNotificheWebhookB2bSteps #654

wants to merge 2 commits into from

Conversation

Vincenzo-Massaro
Copy link
Collaborator

@Vincenzo-Massaro Vincenzo-Massaro commented Jan 31, 2025 •
edited by jira bot
Loading

@Vincenzo-Massaro
First improvement of method readStreamEventsStateV23
7e89f06 
Improvements made:
- removed flag 'found': it was true if and only if notificationStatusHistoryElement != null, so we chose to move the assertion to this variable
- replaced JUnit assertion with AssertJ
- improved descriptions and error messages
- introduced the use of SoftAssertions
- handled the AssertionError exception, thrown by AssertJ instead of AssertionFailedError
@Vincenzo-Massaro
Improved readStreamEventsStateV23 and readStreamTimelineElementV23
432e586
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Vincenzo-Massaro