Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [SRTP-190] fix openapi error response descriptions for activation api #64

Conversation

fmuscianisi
Copy link
Collaborator

Description

Aligned non checked error responses in RTP activation OpenAPI descriptor to match Spring Boot generic error response.

List of Changes

  • Example error responses and labels in OpenPAI descriptor of RTP activation;
  • Catch WebExchangeBindException to abide by BAD REQUEST response body already in place.

Motivation and Context

Resolve aligning issues between activation API description and implementation.

How Has This Been Tested?

  • Pre-Deploy Test
    • Unit
    • Integration (Narrow)
  • Post-Deploy Test
    • Isolated Microservice
    • Broader Integration
    • Acceptance
    • Performance & Load

Types of changes

  • PATCH - Bug fix (backwards compatible bug fixes)
  • MINOR - New feature (add functionality in a backwards compatible manner)
  • MAJOR - Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@fmuscianisi fmuscianisi requested review from a team as code owners January 31, 2025 15:13
@fmuscianisi fmuscianisi force-pushed the SRTP-190-fix-openapi-error-response-descriptions-for-activation-api branch from 7ab20e8 to a7f80eb Compare January 31, 2025 15:25
@fmuscianisi fmuscianisi force-pushed the SRTP-190-fix-openapi-error-response-descriptions-for-activation-api branch from a7f80eb to c84276b Compare January 31, 2025 15:39
@fmuscianisi fmuscianisi changed the title Srtp 190 fix openapi error response descriptions for activation api fix: [SRTP-190] fix openapi error response descriptions for activation api Jan 31, 2025
@fmuscianisi fmuscianisi force-pushed the SRTP-190-fix-openapi-error-response-descriptions-for-activation-api branch from c84276b to a8abc6f Compare February 4, 2025 11:09
@and-mora and-mora merged commit 5b113af into main Feb 4, 2025
9 checks passed
@and-mora and-mora deleted the SRTP-190-fix-openapi-error-response-descriptions-for-activation-api branch February 4, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants