chore: USER_MS_ACTIVE prod to true (#247)

pagopa · Apr 30, 2024 · 51f4d0d · 51f4d0d
1 parent fb4871d
commit 51f4d0d
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 8 deletions.
diff --git a/...nctions/src/main/java/it/pagopa/selfcare/onboarding/service/CompletionServiceDefault.java b/...nctions/src/main/java/it/pagopa/selfcare/onboarding/service/CompletionServiceDefault.java
@@ -210,17 +210,18 @@ public void sendCompletedEmail(Onboarding onboarding) {
     @Override
     public void persistUsers(Onboarding onboarding) {
         if(isUserMSActive) {
-            List<User> users = onboarding.getUsers();
-            users.forEach(user -> {
+
+            for(User user: onboarding.getUsers()) {
                 AddUserRoleDto userRoleDto = userMapper.toUserRole(onboarding);
                 userRoleDto.setUserMailUuid(user.getUserMailUuid());
                 userRoleDto.setProduct(productMapper.toProduct(onboarding, user));
                 userRoleDto.getProduct().setTokenId(onboarding.getId());
-                Response response = userApi.usersUserIdPost(user.getId(), userRoleDto);
-                if(!SUCCESSFUL.equals(response.getStatusInfo().getFamily())) {
-                    throw new RuntimeException("Impossible to create or update role for user with ID: " + user.getId());
+                try (Response response = userApi.usersUserIdPost(user.getId(), userRoleDto)) {
+                    if (!SUCCESSFUL.equals(response.getStatusInfo().getFamily())) {
+                        throw new RuntimeException("Impossible to create or update role for user with ID: " + user.getId());
+                    }
                 }
-            });
+            }
         }
     }
 

diff --git a/infra/container_apps/hub_spid_login/container_app.tf b/infra/container_apps/hub_spid_login/container_app.tf
@@ -23,6 +23,7 @@ module "container_app_hub_spid_login" {
       timeoutSeconds   = 5
       type             = "Liveness"
       failureThreshold = 5
+      initialDelaySeconds = 1
     },
     {
       httpGet = {
@@ -33,6 +34,7 @@ module "container_app_hub_spid_login" {
       timeoutSeconds   = 5
       type             = "Readiness"
       failureThreshold = 3
+      initialDelaySeconds = 3
     },
     {
       httpGet = {
@@ -43,6 +45,7 @@ module "container_app_hub_spid_login" {
       timeoutSeconds   = 5
       failureThreshold = 30
       type             = "Startup"
+      initialDelaySeconds = 30
     }
   ]
 

diff --git a/infra/container_apps/onboarding-ms/container_app.tf b/infra/container_apps/onboarding-ms/container_app.tf
@@ -24,6 +24,7 @@ module "container_app_onboarding_ms" {
       timeoutSeconds   = 5
       type             = "Liveness"
       failureThreshold = 3
+      initialDelaySeconds = 1
     },
     {
       httpGet = {
@@ -34,6 +35,7 @@ module "container_app_onboarding_ms" {
       timeoutSeconds   = 5
       type             = "Readiness"
       failureThreshold = 30
+      initialDelaySeconds = 3
     },
     {
       httpGet = {
@@ -44,6 +46,7 @@ module "container_app_onboarding_ms" {
       timeoutSeconds   = 5
       failureThreshold = 5
       type             = "Startup"
+      initialDelaySeconds = 5
     }
   ]
 

diff --git a/infra/functions/onboarding-functions/env/prod-pnpg/terraform.tfvars b/infra/functions/onboarding-functions/env/prod-pnpg/terraform.tfvars
@@ -84,5 +84,5 @@ app_settings = {
   "MAIL_ONBOARDING_CONFIRMATION_LINK"                  = "https://imprese.notifichedigitali.it/onboarding/confirm?jwt=",
   "MAIL_ONBOARDING_REJECTION_LINK"                     = "https://imprese.notifichedigitali.it/onboarding/cancel?jwt=",
   "MAIL_ONBOARDING_URL"                                = "https://imprese.notifichedigitali.it/onboarding/",
-  "USER_MS_ACTIVE"                                     = "false"
+  "USER_MS_ACTIVE"                                     = "true"
 }
diff --git a/infra/functions/onboarding-functions/env/prod/terraform.tfvars b/infra/functions/onboarding-functions/env/prod/terraform.tfvars
@@ -75,7 +75,7 @@ app_settings = {
   "MS_USER_URL"                                        = "https://selc-p-user-ms-ca.greensand-62fc96da.westeurope.azurecontainerapps.io",
   "MS_PARTY_REGISTRY_URL"                              = "https://selc-p-party-reg-proxy-ca.greensand-62fc96da.westeurope.azurecontainerapps.io",
 #  "MS_PARTY_REGISTRY_URL"                              = "https://selc.internal.selfcare.pagopa.it/party-registry-proxy/v1",
-  "USER_MS_ACTIVE"                                     = "false"
+  "USER_MS_ACTIVE"                                     = "true"
 
   ##ARUBA SIGNATURE
   "PAGOPA_SIGNATURE_SOURCE"                        = "aruba",