reusable for function

.github/workflows/code_review_functions.yml

@@ -1,44 +1,31 @@
 name: Code Review onboarding-functions
 
 on:
+  workflow_dispatch:
+
   pull_request:
     branches:
       - main
     types:
       - opened
+      - edited
       - synchronize
       - reopened
+      - ready_for_review
     paths:
       - 'apps/onboarding-functions/**'
-
-  workflow_dispatch:
+      - 'apps/onboarding-ms/pom.xml'
+      - '.github/workflows/code_review_functions.yml'
+      - '.github/workflows/call_code_review.yml'
 
 jobs:
 
-  code-review:
-    runs-on: ubuntu-latest
-    permissions:
-      packages: read
-      id-token: write
-    steps:
-      - name: Setup Maven Action
-        uses: s4u/setup-maven-action@fa2c7e4517ed008b1f73e7e0195a9eecf5582cd4 # [email protected]
-        with:
-          checkout-fetch-depth: 0
-          java-version: 17
-          java-distribution: 'temurin'
-          maven-version: '3.9.5'
-          cache-enabled: true
-
-      - name: Build and analyze on Pull Requests
-        shell: bash
-        run: mvn --projects :test-coverage --also-make verify -Ponboarding-functions,report,coverage
-          -Dsonar.organization=pagopa
-          -Dsonar.projectKey=pagopa_selfcare-onboarding
-          -Dsonar.token=${{ secrets.SONAR_TOKEN }}
-          -Dsonar.pullrequest.key=${{ github.event.pull_request.number }}
-          -Dsonar.pullrequest.branch=${{ github.head_ref }}
-          -Dsonar.pullrequest.base=refs/remotes/origin/${{ github.base_ref }}
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+  code_review:
+    uses: ./.github/workflows/call_code_review.yml
+    name: OnBoarding function Code Review
+    secrets: inherit
+    with:
+      pr_number: ${{ github.event.pull_request.number }}
+      source_branch: ${{ github.head_ref }}
+      target_branch: ${{ github.base_ref }}
+      sonar_key: 'pagopa_selfcare-onboarding'

.github/workflows/code_review_ms.yml

@@ -11,17 +11,12 @@ on:
       - edited
       - synchronize
       - reopened
-      # - ready_for_review # TODO: re enable
+      - ready_for_review
     paths:
       - 'apps/onboarding-ms/**'
       - 'apps/onboarding-ms/pom.xml'
       - '.github/workflows/code_review_ms.yml'
-      - '.github/workflows/templates/call_code_review.yml'
-
-  # TODO: remove, just for testing
-  push:
-    branches:
-      - EC-95-pipeline-code-review-con-reusable-workflows
+      - '.github/workflows/call_code_review.yml'
 
 jobs: