remove unsued steps

.github/workflows/deploy_onboarding_functions.yml

@@ -36,9 +36,6 @@ jobs:
     runs-on: ubuntu-latest
     if: ${{ (github.event_name == 'workflow_dispatch' || github.event.pull_request.merged == 'true') }}
     environment: "${{ inputs.environment != null && inputs.environment || (github.base_ref == 'main' && 'prod' || (github.base_ref == 'develop' && 'uat' || 'dev')) }}-cd"
-    outputs:
-      environment: ${{ steps.setenv.outputs.environment }}
-      short_sha: ${{ steps.setsha.outputs.short_sha }}
     permissions:
       packages: write
       contents: write
@@ -50,22 +47,6 @@ jobs:
         with:
           ref: ${{ github.ref_name }}
 
-      # this workaround is necessary to pass the environment value to the next job
-      # unexpectly, global env vars cannot be read to set the environment and I don't
-      # want to repeat that complex expression (already repeated twice)
-      - name: Read Environment
-        id: setenv
-        shell: bash
-        run: |
-          echo "environment=$ENV_NAME" >> $GITHUB_OUTPUT
-
-      # github doesn't provide a short sha anymore
-      - name: Set Short Git Commit SHA
-        id: setsha
-        run: |
-          calculatedSha=$(git rev-parse --short ${{ github.sha }})
-          echo "short_sha=sha-$calculatedSha" >> $GITHUB_OUTPUT
-
       - name: Set up JDK 17
         uses: actions/setup-java@v3
         with:

.identity/03_github_environment.tf

@@ -84,7 +84,7 @@ resource "github_actions_environment_secret" "github_environment_cd_secrets" {
 resource "github_actions_environment_variable" "github_environment_cd_variables" {
   for_each      = local.env_variables
   repository    = local.github.repository
-  environment     = github_repository_environment.environment_cd.environment
+  environment   = github_repository_environment.environment_cd.environment
   variable_name = each.key
   value         = each.value
 }