Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SELC-3198] feat: using ProductServiceCacheable #123

Merged
merged 6 commits into from
Jan 25, 2024
Merged

[SELC-3198] feat: using ProductServiceCacheable #123

merged 6 commits into from
Jan 25, 2024

Conversation

manuraf
Copy link
Contributor

@manuraf manuraf commented Jan 25, 2024

List of Changes

  • Fix product sdk
  • Config ProductServiceCacheable as productService

Motivation and Context

ProductServiceCacheable is used for obtain product configuration real-time updated.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@manuraf manuraf requested a review from a team as a code owner January 25, 2024 16:49
@github-actions github-actions bot added functions Changes are related to functions onboarding-ms libs labels Jan 25, 2024
@manuraf manuraf changed the base branch from main to ops/fix-code-review-function January 25, 2024 16:50
@manuraf manuraf closed this Jan 25, 2024
@manuraf manuraf reopened this Jan 25, 2024
@manuraf manuraf closed this Jan 25, 2024
@manuraf manuraf reopened this Jan 25, 2024
Base automatically changed from ops/fix-code-review-function to main January 25, 2024 17:09
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@manuraf manuraf merged commit c30fc0d into main Jan 25, 2024
13 of 14 checks passed
@manuraf manuraf deleted the feature/SELC-3198 branch January 25, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
functions Changes are related to functions libs onboarding-ms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@manuraf