Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC - 3922] feat: moved recipient code check and added check if institution is pr… #128

Merged
merged 5 commits into from
Jan 29, 2024

Conversation

gianmarcoplutino
Copy link
Contributor

…esent on IPA

List of Changes

  • Moved recipientCode check in customValidate method
  • added check if institution is present on IPA before create it
  • implemented unit test

Motivation and Context

These changes were necessary as they had been made respectively in the Core microservice and in the onboarding-backend microservice but had not yet been transcribed into the new onboarding microservice

How Has This Been Tested?

the microservice was started locally, along with the onboarding-backend microservice, and onboarding calls were made to verify that the controls are working

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions github-actions bot added functions Changes are related to functions onboarding-ms labels Jan 29, 2024
@gianmarcoplutino gianmarcoplutino marked this pull request as ready for review January 29, 2024 11:54
@gianmarcoplutino gianmarcoplutino requested a review from a team as a code owner January 29, 2024 11:54
@github-actions github-actions bot added the ops label Jan 29, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@gianmarcoplutino gianmarcoplutino merged commit 7f1ae5b into main Jan 29, 2024
5 of 7 checks passed
@gianmarcoplutino gianmarcoplutino deleted the feature/SELC-3922 branch January 29, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functions Changes are related to functions onboarding-ms ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants