Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC-3996] feat: PNPG onboarding use case #129

Merged
merged 6 commits into from
Jan 29, 2024
Merged

[SELC-3996] feat: PNPG onboarding use case #129

merged 6 commits into from
Jan 29, 2024

Conversation

manuraf
Copy link
Contributor

@manuraf manuraf commented Jan 29, 2024

List of Changes

  • Added endpoint POST for onboarding PG institution /pg/completion with CONFIRMATION workflow
  • Move transaction close before calling endpoint orchestration, it is necessary for handle sync response from orchestration function
  • TrustedListsCertificateSource refresh list based on signature enabled, in pnpg signature will be disabled

Motivation and Context

Implementation of PNPG onboarding use case where response must be sync. Sync response was already implemented but some bug because transaction of persisting onboarding was closed after calling orchestration. This caused onboarding not found when orchestration performed the find on start of the orchestration.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@manuraf manuraf requested a review from a team as a code owner January 29, 2024 12:04
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@manuraf manuraf merged commit 28d691b into main Jan 29, 2024
6 checks passed
@manuraf manuraf deleted the feature/SELC-3996 branch January 29, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant