Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save product role when onboarding #137

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

manuraf
Copy link
Contributor

@manuraf manuraf commented Feb 2, 2024

List of Changes

  • Refactor retrieve and saving user when onboarding, productRole missed
  • Limit onboarding response removing taxcode and mail

Motivation and Context

ProductRole was not being saved during the onboarding request

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@manuraf manuraf requested a review from a team as a code owner February 2, 2024 08:49
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

12 New issues
0 Security Hotspots
87.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@manuraf manuraf merged commit 2459c9d into main Feb 2, 2024
8 checks passed
@manuraf manuraf deleted the bugfix/save-product-role branch February 2, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant