Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: orchestration sync return internal server error #187

Merged
merged 2 commits into from
Feb 23, 2024
Merged

fix: orchestration sync return internal server error #187

merged 2 commits into from
Feb 23, 2024

Conversation

manuraf
Copy link
Contributor

@manuraf manuraf commented Feb 23, 2024 •
edited
Loading

List of Changes

  • Return internal server error if orchestration metadata has status FAILED
  • Fix some prod env valued

Motivation and Context

In PNPG use case onboarding process must fail returning internal server error if some errors happen

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@manuraf manuraf requested review from a team as code owners February 23, 2024 10:58
@github-actions github-actions bot added functions Changes are related to functions ops hotfix labels Feb 23, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
75.0% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@manuraf manuraf merged commit a2c74b4 into releases/0.0.4 Feb 23, 2024
4 of 6 checks passed
@manuraf manuraf deleted the bugfix/handle-failed-orchestration branch February 23, 2024 11:04
manuraf added a commit that referenced this pull request Feb 23, 2024
@manuraf
fix: orchestration sync return internal server error (#187)
74e7404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
functions Changes are related to functions hotfix ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@manuraf