Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC - 4393]feat: implemented new method for onboarding reject API #197

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

gianmarcoplutino
Copy link
Contributor

List of Changes

  • Added new ReasonRequest Object with reasonForReject attribute
  • A new method has been added so that when the onboarding request is rejected by the PagoPA operator, in addition to changing the status, the new reasonForReject field is saved on the DB Entity

Motivation and Context

This change allows you to also inform via PEC the reason why your request was rejected by the PagoPA operator

How Has This Been Tested?

the API was invoked locally and it was verified that the status was updated from TOBEVALIDATE to REJECTED and it was also verified that the new reasonForReject attribute was saved.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gianmarcoplutino gianmarcoplutino marked this pull request as ready for review March 4, 2024 15:28
@gianmarcoplutino gianmarcoplutino requested a review from a team as a code owner March 4, 2024 15:29
Copy link

sonarqubecloud bot commented Mar 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@manuraf manuraf merged commit d78efdd into main Mar 6, 2024
7 of 9 checks passed
@manuraf manuraf deleted the feature/SELC-4393 branch March 6, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants