Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC - 4395] feat: mapping new reasonForReject attribute during send reject mail p… #200

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

gianmarcoplutino
Copy link
Contributor

…rocess

List of Changes

  • the mapping of the reasonForReject attribute has been added during the phase of retrieving and sending the reject email

Motivation and Context

This change was made so that the end user could understand the reason why his membership request was rejected by the PagoPA operator

How Has This Been Tested?

the function was invoked locally and it was verified that the attribute retrieved from the DB was correctly mapped to the email template

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions github-actions bot added functions Changes are related to functions onboarding-ms labels Mar 6, 2024
@gianmarcoplutino gianmarcoplutino marked this pull request as ready for review March 6, 2024 16:39
@gianmarcoplutino gianmarcoplutino requested a review from a team as a code owner March 6, 2024 16:39
# Conflicts:
#	apps/onboarding-functions/src/main/java/it/pagopa/selfcare/onboarding/entity/Onboarding.java
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@manuraf manuraf merged commit 2d71e01 into main Mar 7, 2024
4 of 5 checks passed
@manuraf manuraf deleted the feature/SELC-4395 branch March 7, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functions Changes are related to functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants