Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC - 4353] feat: removed file attachment to mail (contract) during onboarding phase #210

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

gianmarcoplutino
Copy link
Contributor

List of Changes

  • removed file attachment to mail (contract) during onboarding phase
  • Renaming all methods and variables that contained "withContract" to "forContract"

Motivation and Context

This change was necessary because the onboarding flow has changed and now the contract will be downloaded from a dedicated FE page and will no longer be sent as an attachment in the PEC that reaches the institution

How Has This Been Tested?

Once the flow was modified, the function was invoked and it was verified that the file was not attached via email

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gianmarcoplutino gianmarcoplutino requested a review from a team as a code owner March 22, 2024 08:36
@github-actions github-actions bot added the functions Changes are related to functions label Mar 22, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@gianmarcoplutino gianmarcoplutino merged commit 5f01326 into main Mar 25, 2024
4 of 5 checks passed
@gianmarcoplutino gianmarcoplutino deleted the feature/SELC-4353 branch March 25, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functions Changes are related to functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants