Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace selfcare-commons with onboarding-sdk-commons #28

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

manuraf
Copy link
Contributor

@manuraf manuraf commented Oct 26, 2023

List of Changes

  • Remove selc-commos from parent pom.
  • Replace selc-commos InstitutionType and PartyRole with the same object in onboarding-sdk-common

Motivation and Context

Selfcare-commons includes a lot libraries that are not needed on onboarding domain, for example spring boot sdk. It causes extra time in building and over size of jar package for onboarding artifact. Sdk should be small as possibile, so we decide to use onboarding-sdk-common that contains only few utilty classes.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@manuraf manuraf requested a review from a team as a code owner October 26, 2023 10:33
@github-actions github-actions bot added functions Changes are related to functions ms sdk labels Oct 26, 2023
@manuraf manuraf merged commit 17bc497 into develop Oct 30, 2023
3 checks passed
@manuraf manuraf deleted the feature/remove-selc-commons branch October 30, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functions Changes are related to functions ms sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants