Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor onboarding-sdk-product setting java 17 #32

Merged
merged 7 commits into from
Nov 3, 2023

Conversation

manuraf
Copy link
Contributor

@manuraf manuraf commented Nov 3, 2023

List of Changes

  • Refactor ProductServiceDefault for reducing code and adding java doc
  • Set Java 17
  • Update README
  • Refactor release workflow for only deploy version

Motivation and Context

ProductServiceDefault miss about documentation on single method so it is difficult for developer know what expected from its method. API should have documentation for improving usage of developer.

Java 11 will be not supported soon for Selfcare so Java 17 is also the new minimum version for SDK.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@manuraf manuraf requested a review from a team as a code owner November 3, 2023 09:57
@manuraf manuraf merged commit 4e39cf8 into develop Nov 3, 2023
3 checks passed
@manuraf manuraf deleted the docs/upgrade-readme-and-test branch November 3, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants