Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: monorepo folder structure #34

Merged
merged 7 commits into from
Nov 7, 2023
Merged

Conversation

manuraf
Copy link
Contributor

@manuraf manuraf commented Nov 6, 2023

List of Changes

  • Set new folder structure following monorepo principles
  • Move onboarding-ms and onboarding-functions project under apps/ folder
  • Move onboarding-sdk project under libs/ folder
  • Align github action to new folder structure

NB. Sorry for PR size but we move entire project under new folders

Motivation and Context

Selfcare-onboarding repo want to follow monorepo principles so it has to follow an appropriate structure of folders. apps/ directory contains now applications and libs/ contains all the common libraries.

This repo use Maven as build tool for monorepo, it is really not a monorepo-native build tool but can be made good use of with some tricks and usage of a couple of lesser known command line switches. We provide some commands to build applications and libs in README root.

We looked at this repo as example of java monorepo https://github.com/SpareBank1/monorepo-sample

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@manuraf manuraf marked this pull request as ready for review November 6, 2023 15:55
@manuraf manuraf requested a review from a team as a code owner November 6, 2023 15:55
@manuraf manuraf merged commit 47e17c7 into develop Nov 7, 2023
3 checks passed
@manuraf manuraf deleted the refactor/monorepo-structure branch November 7, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants