Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: replace business logic for retrieving product with onboarding-sdk-product #36

Merged
merged 21 commits into from
Nov 9, 2023

Conversation

manuraf
Copy link
Contributor

@manuraf manuraf commented Nov 8, 2023

List of Changes

  • Replace business logic for retrieving product by REST API with using onboarding-sdk-product.
  • Fix code review workflow
  • Added properties for disable orchestration async workflow

Motivation and Context

Currently, product records that represents which are handled by selfcare are stored in a MongoDB collection which are accessible through a REST API.
We are planning to replace this architecture with a file-based approach in our roadmap implemented by Onboarding SDK Product which offers a set of classes designed for managing this collection of records using a file. This file is stored in azure container storage as json.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@manuraf manuraf requested a review from a team as a code owner November 8, 2023 14:08
@manuraf manuraf changed the title Refactor: replace product api retrieving with onboarding-sdk-product Refactor: replace business logic for retrieving produc with onboarding-sdk-product Nov 8, 2023
@manuraf manuraf changed the title Refactor: replace business logic for retrieving produc with onboarding-sdk-product Refactor: replace business logic for retrieving product with onboarding-sdk-product Nov 8, 2023
@manuraf manuraf merged commit ae7d026 into develop Nov 9, 2023
3 of 4 checks passed
@manuraf manuraf deleted the refactor/replace-product-api branch November 9, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants