generated from pagopa/pagopa-functions-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: replace business logic for retrieving product with onboarding-sdk-product #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuraf
changed the title
Refactor: replace product api retrieving with onboarding-sdk-product
Refactor: replace business logic for retrieving produc with onboarding-sdk-product
Nov 8, 2023
manuraf
changed the title
Refactor: replace business logic for retrieving produc with onboarding-sdk-product
Refactor: replace business logic for retrieving product with onboarding-sdk-product
Nov 8, 2023
gianmarcoplutino
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Motivation and Context
Currently, product records that represents which are handled by selfcare are stored in a MongoDB collection which are accessible through a REST API.
We are planning to replace this architecture with a file-based approach in our roadmap implemented by Onboarding SDK Product which offers a set of classes designed for managing this collection of records using a file. This file is stored in azure container storage as json.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: