[SELC-3158] feat: send mail async with contract #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
gianmarcoplutino
approved these changes
Nov 10, 2023
gunzip
reviewed
Nov 10, 2023
| @@ -77,7 +94,8 @@ public File createContractPDF(String contractTemplatePath, Onboarding onboarding | |||
| log.debug("data Map for PDF: {}", data); | |||
| getPDFAsFile(files, contractTemplateText, data); | |||
|
|
|||
| //return signContract(institution, request, files.toFile()); | |||
| // Define the filename and path for storage. | |||
| /* return signContract(institution, request, files.toFile()); */ | |||
| final String filename = String.format(PDF_FORMAT_FILENAME, onboarding.getOnboardingId()); | |||
There was a problem hiding this comment.
this will overwrite the file on azure storage for subsequent calls, is this right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Motivation and Context
This pull request introduces a enhancement by implementing a new asynchronous step in the workflow. Specifically, it enables the seamless initiation of an email dispatch during the onboarding of an organization from the frontend, along with the attachment of the corresponding contract.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: