Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC - 3390] feat: removed notEmpty to recipientCode in /onboarding API and added … #44

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

gianmarcoplutino
Copy link
Contributor

…InstitutionLocationData with city, county, country information

List of Changes

  • removed of the mandatory recipientCode field to /onboarding API
  • added BillingPa
  • added InstitutionLocationData object with city, county and country information

Motivation and Context

  • The InstitutionLocationData object was added to align this new repo with selfcare updates
  • the mandatory recipientCode field has been removed to allow insurance onboarding

How Has This Been Tested?

the application was started locally and tests were carried out to verify that the IVASS institutions were onboarded correctly and that the new fields present in InstitutionLocationData were stored

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

…InstitutionLocationData with city, county, country information
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 142 Code Smells

0.0% 0.0% Coverage
2.8% 2.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@gianmarcoplutino gianmarcoplutino merged commit 29a1279 into develop Nov 17, 2023
5 of 6 checks passed
@gianmarcoplutino gianmarcoplutino deleted the feature/SELC-3390 branch November 17, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants